Closed Bug 1447616 Opened 6 years ago Closed 6 years ago

Massive Xpcshell test failure 2018-03-21: 29 failures

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 61.0

People

(Reporter: jorgk-bmo, Unassigned)

Details

Attachments

(2 files, 1 obsolete file)

1447616-task.patch (v2)
37.77 KB, patch
Details | Diff | Splinter Review
1447616-task-follow-up.patch
4.10 KB, patch
Details | Diff | Splinter Review 
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_offlinePlayback.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_offlinePlayback.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_mailstoreConverter.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_mailstoreConverter.js | testMaildirConversion - [testMaildirConversion : 85] 0 == 1000
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_mailstoreConverter.js | testMaildirConversion - [testMaildirConversion : 131] false == true
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_mailstoreConverter.js | testMaildirConversion - [testMaildirConversion : 257] A promise chain failed to handle a rejection: [Exception... "Abort" nsresult: "0x80004004 (NS_ERROR_ABORT)" location: "JS frame :: /Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js :: _abort_failed_test :: line 723" data: no] - stack: _do_main@/Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js:211:3
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_copyThenMoveManual.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_copyThenMoveManual.js | verifyFolders1 - [verifyFolders1 : 58] 0 == 1
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_converterDeferredAccount.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_converterDeferredAccount.js | testMaildirConversion - [testMaildirConversion : 90] 0 == 1000
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_converterDeferredAccount.js | testMaildirConversion - [testMaildirConversion : 177] false == true
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_converterDeferredAccount.js | testMaildirConversion - [testMaildirConversion : 257] A promise chain failed to handle a rejection: [Exception... "Abort" nsresult: "0x80004004 (NS_ERROR_ABORT)" location: "JS frame :: /Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js :: _abort_failed_test :: line 723" data: no] - stack: _do_main@/Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js:211:3
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_folderCompact.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_folderCompact.js | lastTestCheck - [lastTestCheck : 290] "undefined" == 0
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_quarantineFilterMove.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_quarantineFilterMove.js | verifyFolders1 - [verifyFolders1 : 45] 0 == 2
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_downloadOffline.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_imapID.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_offlineCopy.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_subfolderLocation.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_cacheParts.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_downloadOffline.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_imapID.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_offlineCopy.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_subfolderLocation.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/local/test/unit/test_pop3FilterActions.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/local/test/unit/test_pop3MoveFilter.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/local/test/unit/test_pop3MoveFilter2.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/local/test/unit/test_pop3MoveFilter2.js | verifyFolders2 - [verifyFolders2 : 56] 0 == 1

M-C last good: 6d0f84afc194e287b6f144d17cd88371a5
M-C first bad: e636edf00e6fbdc3206c9df4a1548ae38b
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6d0f84afc194e287b6f144d17cd88371a5&tochange=e636edf00e6fbdc3206c9df4a1548ae38b
which is the merge this morning.

Log
https://taskcluster-artifacts.net/NIQGjCpNR8CSIGLb_nMW3g/0/public/logs/live_backing.log
shows:
test_converterDeferredAccount.js, line 176: ReferenceError: reference to undefined property "error"
which is from:
log.error("Conversion failed: " + reason.error);
but that looks just like a secondary problem where something failed and the error reporting failed as well :-(

Looking for TypeError I see 22 matches, for example:
TypeError: IMAPPump.daemon is null at /Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/tests/comm/mailnews/imap/test/unit/test_imapID.js:31
TypeError: IMAPPump.inbox is null at /Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/tests/comm/mailnews/imap/test/unit/test_offlineCopy.js:125
TypeError: gUidValidity is undefined at /Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/tests/comm/mailnews/imap/test/unit/test_cacheParts.js:145

Looks like this comes from
https://hg.mozilla.org/mozilla-central/rev/e2a78fa784c6
Bug 1446833: Part 2 - Stop using Task.jsm in xpcshell/head.js. r=florian

Or maybe not since test_cacheParts.js already uses
function run_test() {
  tests.forEach(x => add_task(x));
  run_next_test();
}

Aceman, could you assist? Florian, any hints?

Mozmill is not affected and this looks like test failures and not functional failures.
Flags: needinfo?(florian)
Flags: needinfo?(acelists)
These tests use generators as tasks. We removed all occurrences of that in m-c in bug 1353542 and bug 1374282.

You need to replace all the 'yield' with 'await', and all the 'function*' with 'async function' and that should work. I have scripts in the bugs mentioned above that could do that automatically. They may have bitrotted by now...

I couldn't just run them in all of Thunderbird's code because gloda uses plenty of generators :-(. Some of the work will need to happen by hand. Or someone needs to convert gloda to use async functions instead of its own magic based on generators.
Flags: needinfo?(florian)
comm/mailnews/imap/test/unit/test_offlinePlayback.js:
04:21:35     INFO -  Unexpected exception NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgFolder.getChildNamed]
04:21:35     INFO -  prepareToGoOffline@/Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/tests/comm/mailnews/imap/test/unit/test_offlinePlayback.js:28:21
04:21:35     INFO -  run_next_test/_run_next_test/<@/Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js:1418:22
04:21:35     INFO -  async*_run_next_test@/Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js:1418:10
04:21:35     INFO -  run@/Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js:669:9
04:21:35     INFO -  _do_main@/Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js:211:3
04:21:35     INFO -  _execute_test@/Users/cltbld/tasks/task_1521630803/build/tests/xpcshell/head.js:517:5
(In reply to Florian Quèze [:florian] from comment #1)
> These tests use generators as tasks. We removed all occurrences of that in
> m-c in bug 1353542 and bug 1374282.
Hmm, but these landed long ago.

> Or
> someone needs to convert gloda to use async functions instead of its own
> magic based on generators.
That's been on the books for ages.

I'm still interested to know what caused the bustage we're seeing now.
(In reply to Jorg K (GMT+1) from comment #3)

> I'm still interested to know what caused the bustage we're seeing now.

You said it in comment 0:
(In reply to Jorg K (GMT+1) from comment #0)

> Looks like this comes from
> https://hg.mozilla.org/mozilla-central/rev/e2a78fa784c6
> Bug 1446833: Part 2 - Stop using Task.jsm in xpcshell/head.js. r=florian


Task.jsm was compatible with both generators and async functions. Yesterday we made xpcshell tests stop using Task.jsm, so now only async functions are supported.
In case anyone is following, I'm doing the manual conversion, starting with IMAP. Two passed so far.
Attached patch 1447616-task.patch (obsolete) — — Splinter Review 
This fixes
IMAP:  mozilla/mach xpcshell-test mailnews/imap/test/unit/
Flags: needinfo?(acelists)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0a725681fe43
Port bug 1446833 (Part 2): don't rely on Task.jsm. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
Missed some, how strange. test_autoReply.js doesn't run on Mac, but the other one passed on try. Strange.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e2d00a308beb
Port bug 1446833 (Part 2): don't rely on Task.jsm (take 2). rs=bustage-fix DONTBUILD
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: