1447644 - Consider removing extra fields from reported histograms

Status: NEW

(Toolkit :: Telemetry, enhancement, P4)

Description

[Frank Bertsch [:frank]]

Reported histograms are currently sending the following fields (consistently): ["range", "bucket_count", "histogram_type", "sum", "values"]. Of those, only ["sum", "values"] are not indicated by the histogram definition. We'll need to check whether any pieces of the pipeline use those extra fields ("range", "bucket_count", and "histogram_type"). If not they are safe to remove.

Comment 1

[Chris H-C :chutten]

They may be useful for determining the type and bucket layout of dynamic histograms. We don't currently support any non-static histograms, but we did in the past (and might again in the future).

It is possible that, with the probe info service, we will never need them.

Comment 2

[Frank Bertsch [:frank]]

(In reply to Chris H-C :chutten from comment #1)
> They may be useful for determining the type and bucket layout of dynamic
> histograms. We don't currently support any non-static histograms, but we did
> in the past (and might again in the future).
> 
> It is possible that, with the probe info service, we will never need them.

The plan for dynamic scalars is to require definitions _somewhere_ for the pipeline (they can live in other repos, though, so long as they're accessible over http. Or ftp, if that's what you want, fine.) I assume we'll do the same for histograms.