1447880 - blob-image: Use clipping when possible for nsDisplayMask

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

Currently we take a bad DrawItemAsLayer path. In the cases where we can get an actual clip path we should use that instead.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

nsSVGIntegrationUtils::PaintMaskAndClipPath() should be using a clip path when possible. See "MaskUsage"

Comment 2

[Jeff Muizelaar [:jrmuizel]]

If we take some pieces of PaintMaskAndClipPath() we should be able to do regular clipping for clip paths.

Also, the layer building/paint as layers stuff shows up in profiles:
https://perfht.ml/2qJFmZ6

Comment 3

[Jeff Muizelaar [:jrmuizel]]

We can use nsDisplayMask::PaintMask and PushLayer/PopLayer for the cases where we don't have a clip path.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

This will need some kind of solution for handing 3d transforms inside of masks. That could be just making those masks active.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

3d transforms inside of masks can be handled with BasicLayerManager.

It should be that the frame for the nsDisplayMask gets marked as invalid when the mask changes.

We should be able to chop PaintMaskAndClipPath in half if we can get control of the state that it needs between starting the clip and ending the clip.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: WIP

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1447880. Handle inactive 3d transforms

It isn't possible to trigger this code currently because
the only way to have an inactive 3d transform is with a mask
or filter item and those get handled with a BasicLayerManager.

This becomes necessary once we handle mask items internally.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1447880. Allow PaintMaskAndClipPath to support different ways of painting its children

Depends on 6222

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1447880. Paint nsDisplayMasks directly instead of using a BasicLayerManager

This allows us to invalidate individual items inside of the mask instead of
treating the mask and it's children as a single item.

Depends on 6223

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 9010127 [details]
Bug 1447880. Paint nsDisplayMasks directly instead of using a BasicLayerManager

Markus Stange [:mstange] has approved the revision.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d89177e1bbc6c870f3cf10d2ea89838aa3966c3

Comment 12

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4b097a1a26d5938b63104dbbf7f34440da47fc6

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1447880. Add nsDisplayMask::IsValidMask

This pulls out a nsDisplayMask::Valid that can be used by
blob invalidation to ensure that the mask is drawable.

Comment 14

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76fc0d63ae36b35ccd2055507c48c89ad91d2d41

Comment 15

[Markus Stange [:mstange]]

Comment on attachment 9010993 [details]
Bug 1447880. Add nsDisplayMask::IsValidMask

Markus Stange [:mstange] has approved the revision.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f0db2886781
Handle inactive 3d transforms. r=mstange
https://hg.mozilla.org/integration/mozilla-inbound/rev/78784961fe2c
Allow PaintMaskAndClipPath to support different ways of painting its children. r=mstange
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3136af29c89
Add nsDisplayMask::IsValidMask. r=mstange
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cd110df8612
Paint nsDisplayMasks directly instead of using a BasicLayerManager. r=mstange

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4f0db2886781
https://hg.mozilla.org/mozilla-central/rev/78784961fe2c
https://hg.mozilla.org/mozilla-central/rev/e3136af29c89
https://hg.mozilla.org/mozilla-central/rev/5cd110df8612