1447952 - Use relative time format in the site data manager

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

In my opinion, the dates in the site data manager are a little hard to grasp at first sight. We recently added support for RelativeTimeFormat in Gecko: https://groups.google.com/forum/?fromgroups=&hl=en#!topic/firefox-dev/P8ll42qpbZc

That would allow us to go from 04/27/18, 09:36 PM to "five minutes ago" or "2 months ago".

Sounds like an improvement to me!

Comment 1

[Johann Hofmann [:johannh]]

The code that would need to change is here: https://searchfox.org/mozilla-central/rev/4114ad2cfcbc511705c7865a4a34741812f9a2a9/browser/components/preferences/siteDataSettings.js#67

This is how sync displays relative dates (see bug 1184265): https://searchfox.org/mozilla-central/rev/4114ad2cfcbc511705c7865a4a34741812f9a2a9/browser/base/content/browser-sync.js#634-645

Comment 2

[Johann Hofmann [:johannh]]

Hi Manish, if you're away until May 3rd I would like to give this bug to someone else to be able to land in the 61 timeframe. There's plenty of other bugs to work on later. Are you actively working on this? :)

Thanks!

Comment 3

[Michael Kohler [:mkohler]]

I'd be happy to take over here if Manish is not working on it.

Comment 4

[Johann Hofmann [:johannh]]

I think we can go ahead here, the patch for this shouldn't be too complex either I hope :)

Thanks!

Comment 5

[Johann Hofmann [:johannh]]

Michael, are you still looking at this? :)

Comment 6

[Michael Kohler [:mkohler]]

I will be able to take a look this weekend. Is that okay? I'm happy to give this to someone else if there is somebody who can do it before that :)

Comment 7

[Phabricator Automation]

Attachment: Bug 1447952 - Use relative time format in the site data manager r=johannh

Comment 8

[Michael Kohler [:mkohler]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=516b6ec9c32103022568be9ac69c954bf2bda68b

Comment 9

[Phabricator Automation]

Attachment: Bug 1447952 - Use relative time format in the site data manager r=johannh

Comment 10

[Michael Kohler [:mkohler]]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=335b3a6763abbf13ac067ea62211317ed1982291

Comment 11

[Phabricator Automation]

Comment on attachment 8974518 [details]
Bug 1447952 - Use relative time format in the site data manager r=johannh

Johann Hofmann [:johannh] has approved the revision.

https://phabricator.services.mozilla.com/D1253

Comment 12

[Michael Kohler [:mkohler]]

Updated the patch according to comments.

new try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=126451c5f8509ca97eb30a8541b888773596e595

Comment 13

[Johann Hofmann [:johannh]]

This looks good to me but I can't import the patch due to conflicts. Would you mind rebasing on central and setting checkin-needed?

Thanks!

Comment 14

[Michael Kohler [:mkohler]]

Try after rebase: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6d6a3b55250a514d2beec50d82ce6358ee257f1

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3172bfa5d63
Use relative time format in the site data manager. r=johannh

Comment 16

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/638fa8732dca
Backed out changeset c3172bfa5d63 for frequent browser chrome failures on browser_siteData.js. CLOSED TREE

Comment 17

[Cosmin Sabou [:CosminS]]

This was backed out for frequent browser chrome failures on browser_siteData.js. 
Here is the range https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-searchStr=browser%20chrome&filter-failure_classification_id=2&tochange=638fa8732dca3cabcd1d13b254ac6f7308d91eb8&fromchange=c3172bfa5d63c410f7016de2b23da1adf8244d12&selectedJob=180749242 

Failure log: 
https://treeherder.mozilla.org/logviewer.html#?job_id=180749242&repo=mozilla-inbound&lineNumber=17799
https://treeherder.mozilla.org/logviewer.html#?job_id=180748794&repo=mozilla-inbound&lineNumber=1717

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/638fa8732dca3cabcd1d13b254ac6f7308d91eb8

Comment 18

[Phabricator Automation]

Attachment: Bug 1447952 - Use relative time format in the site data manager r=johannh

Use relative time format in the site data manager

Comment 19

[Michael Kohler [:mkohler]]

So sorry about this. Looks like I completely screwed up the rebase. Johann, would you mind looking at https://phabricator.services.mozilla.com/D1454 to make sure I don't screw up again? This should include all the necessary changes on top of a recent tip. Sorry again!

Comment 20

[Michael Kohler [:mkohler]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7277be72089646c4c3725a52dfa4ebb310fed8b

Comment 21

[Phabricator Automation]

Comment on attachment 8981658 [details]
Bug 1447952 - Use relative time format in the site data manager r=johannh

Johann Hofmann [:johannh] has approved the revision.

https://phabricator.services.mozilla.com/D1454

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c7e33619bde
Use relative time format in the site data manager. r=johannh

Comment 23

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6c7e33619bde