1447998 - Update webrender to 22493328352ba432a7cd89491d81bfaa19bc1bce

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1447286 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ c32585c1ed94d6cad938ecd0ef7db566a367a00d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b057fdd978f0c9632ba048b0b6d182c4d658b9dc
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a248f9206964259600d424b748bc6aecd6dde428

Green

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 80c614ab660bf6cca52594d0e33a0be262a7ac12

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5aef32f0578be62199a4d1ce9a21406dcc3095c9
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54a04c651ab32b9537394e1b502e8f2871d54de2
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da0d55d543c220c3b938f5cbe93b3dc1d90ea232
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb328ee37f4db9b9706bbabe61843231c5016dc2

Green

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ 00b85801f8c09431e5963a9e1dcd1a9087b744b9

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2107810c51a4268467939a5528a47151b50e9124
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c0316adb9862f801e6d101af91bc7fd73d37c31

Some intermittents, but basically green

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 00b85801f8c09431e5963a9e1dcd1a9087b744b9

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f58a8fa82a9c7ed75867993058a03e3b2e58827
https://treeherder.mozilla.org/#/jobs?repo=try&revision=57b045a27e91620631acf51493bec313a199fd4e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab5ab5b3b7e3da979af292bb846bf6694d680ae8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=87c09a6d22f7535205c555b10998120b5915ad07
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e3fc03bdd762309a3ec6b9bf14001ff59dc702f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2abe866d0440416a120318dc3db143d44394fc4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5717bbca504a14d83225e88cf9c176ff9b5b02a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eabcce339117f3a0edf429e531cee925dda82848

Green

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 43c0cde08f71b800d45ad35119bd20b561288a34

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a92e61fbb71b3b6e9825e5bb15e58fd9887fb40f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9463e69cbb13062eaa3656d89efdaa550eb77ef

Green

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ 42fddb4fc8cef8304fb095bad733a5e35584c688

https://treeherder.mozilla.org/#/jobs?repo=try&revision=13d8d5a5ea49b93d23f3061185d06c5be1864576
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c3479acd3c10764e0412b5b64187b0651ec886e

Green

WR @ 9893ea173d8d337b066e803b7bc11b2b30ea135a

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1050df54449def29edbeb3e09edef8db924a6d8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=78d3e7d2c8c7e3d328d66ac1efe4b1d906265d7a

Too much orange for my liking, looks like there's some crashes. Regression range:

*   9893ea17 (HEAD -> master, origin/master, origin/HEAD) Auto merge of #2556 - glennw:remove-text-shadow3, r=Gankro
|\
| * 2afe3d0e Restore the local rect inflation for blurs.
| * e36c0718 Unify text-shadows with the blur filter.
* 53750b8b Auto merge of #2563 - glennw:big-bs, r=kvark
* b0f31e80 Handle box-shadow stretch mode per-axis.

I'll bisect that.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

The crashtest oranges seem to have been a result of changes on m-c (specifically bug 1443912, which eventually got backed out). The R7 PASS was from servo/webrender#2556, I'll annotate that. The rest seems intermittent.

WR @ 53750b8b

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12aae4a8f4d67ff0d3549465d0b9f1479825914b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c57cb6e453ec32c0fe80b33be80117e10f36ee90

Green

WR @ 097bc025ccc85fad7891d3422d2bccefc0e42948

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b083a08fc957f9c90d6e963b1fc95567a96f5710
https://treeherder.mozilla.org/#/jobs?repo=try&revision=925ad72de720a59cd1b2d63f51c1665f21fb290f

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 22493328352ba432a7cd89491d81bfaa19bc1bce

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c317c18591b72a01f70f542f08e4ae707e63f9d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f093bd45973d7f5d1fb5fc77c4a4b5966a28147b

Bustage from the serde thing, servo/webrender#2577. I need to patch on the gecko side.

Comment 9

[Simon Sapin (:SimonSapin)]

Does this need more than `cargo update -p serde_derive && ./mach vendor rust`? Let me know if I can help.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

It was a little more complicated than that. I got a build working locally but for some reason it's failing on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8350e27788d440e12b15fd702b2d627d6084afbd

Not sure why yet, trying to investigate.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Ah, I was being dumb and forgot to update .cargo/config.in. This one should work:

WR @ 22493328352ba432a7cd89491d81bfaa19bc1bce

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b86612cf12155f9034c4e40ef8a23b4ce21b4f23
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b771133805265596ad1ae80ac48510d859d54d2

Comment 12

[Kartikaya Gupta (email:[e-mail])]

The try push is looking good. Let's land the update.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447998 - Update webrender to commit 22493328352ba432a7cd89491d81bfaa19bc1bce.

Review commit: https://reviewboard.mozilla.org/r/231982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231982/

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447998 - Update serde patching to go with WR PR 2577.

Review commit: https://reviewboard.mozilla.org/r/231984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231984/

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447998 - Update cargo lockfile and re-vendor rust dependencies.

Review commit: https://reviewboard.mozilla.org/r/231986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231986/

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447998 - Update reftest annotations for changes in WR PR 2556.

Review commit: https://reviewboard.mozilla.org/r/231988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231988/

Comment 17

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963113 [details]
Bug 1447998 - Update webrender to commit 22493328352ba432a7cd89491d81bfaa19bc1bce.

https://reviewboard.mozilla.org/r/231982/#review237524

Comment 18

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963114 [details]
Bug 1447998 - Update serde patching to go with WR PR 2577.

https://reviewboard.mozilla.org/r/231984/#review237526

Comment 19

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963115 [details]
Bug 1447998 - Update cargo lockfile and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/231986/#review237528

Comment 20

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963116 [details]
Bug 1447998 - Update reftest annotations for changes in WR PR 2556.

https://reviewboard.mozilla.org/r/231988/#review237530

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5119413e930
Update webrender to commit 22493328352ba432a7cd89491d81bfaa19bc1bce. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/d266eaf936d4
Update serde patching to go with WR PR 2577. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a06708e468f9
Update cargo lockfile and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f6f0e4f4e37c
Update reftest annotations for changes in WR PR 2556. r=jrmuizel

Comment 22

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e5119413e930
https://hg.mozilla.org/mozilla-central/rev/d266eaf936d4
https://hg.mozilla.org/mozilla-central/rev/a06708e468f9
https://hg.mozilla.org/mozilla-central/rev/f6f0e4f4e37c