Closed Bug 1448018 Opened 2 years ago Closed 2 years ago

ContainerBoxObject is unused so remove it

Categories

(Core :: XUL, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1109875 made the docshell accessible from the frameloader so ContainerBoxObject isn't used any more.
Attached patch Remove ContainerBoxObject (obsolete) — Splinter Review
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #8961456 - Attachment is obsolete: true
Attachment #8962383 - Flags: review?(bzbarsky)
Comment on attachment 8962383 [details] [diff] [review]
nocontainerboxobject

>+++ b/layout/xul/nsMenuBarListener.cpp
>+  RefPtr<mozilla::dom::EventTarget> topWindowEventTarget =

It's already "using namespace mozilla", so just "dom::EventTarget".

>+++ b/layout/xul/nsMenuFrame.cpp
>+    RefPtr<mozilla::dom::Event> event = NS_NewDOMEvent(mMenu, mPresContext, nullptr);

Likewise, just dom::Event.

>+++ b/layout/xul/nsResizerFrame.cpp
>+  uint16_t inputSource = mozilla::dom::MouseEventBinding::MOZ_SOURCE_UNKNOWN;

dom::MouseEventBinding, for the same reason.

r=me.  Thank you for cleaning this up!
Attachment #8962383 - Flags: review?(bzbarsky) → review+
I filed bug 1448933 on the one comm-central use.
See Also: → 1448933
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0cb92a08c36
remove ContainerBoxObject which is only used to access the docshell, but bug 1448018 made the docshell accessible from the frameloader instead so the container box object is no longer being used. Change some editor tests which just access the docShell directly rather than through the box object, r=bz
https://hg.mozilla.org/mozilla-central/rev/d0cb92a08c36
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.