1448933 - convbrowser.xml should stop getting the docshell from the boxobject

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 1448018.

It should do what toolkit's browser.xml does and just get it from this.frameLoader.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: bug1448933-v1.patch

Thank you for raising this :bz!

This patch gets the doc shell from the frameLoader, similarly to browser.xml, however it is adapted to convbrowser.xml like the getter for the messageManager.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8962466 [details] [diff] [review]
bug1448933-v1.patch

Review of attachment 8962466 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/content/convbrowser.xml
@@ +86,5 @@
> +          <![CDATA[
> +            if (this._docShell) {
> +              return this._docShell;
> +            }
> +            var owner = this.QueryInterface(Ci.nsIFrameLoaderOwner);

This QI call has been removed in m-c in https://hg.mozilla.org/mozilla-central/rev/4b9198e17252#l21.1

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: bug1448933-v2.patch

Gets rid of the QIs for the frameLoader

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8962509 [details] [diff] [review]
bug1448933-v2.patch

Review of attachment 8962509 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks good by code inspection, I haven't tried the patch locally.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/82c2f54ceefd
Get docShell from frameLoader and don't QI for frameLoader in convbrowser.xml. r=florian

Comment 6

[Jorg K (CEST = GMT+2)]

I don't have an Instantbird 61 target milestone, so this needs to go to Thunderbird::Instant Messaging.