Closed Bug 1448933 Opened 5 years ago Closed 5 years ago

convbrowser.xml should stop getting the docshell from the boxobject

Categories

(Thunderbird :: Instant Messaging, enhancement)

Product:
Thunderbird
Component:
Instant Messaging
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 61.0

People

(Reporter: bzbarsky, Assigned: freaktechnik)

References

Details

Attachments

(1 file, 1 obsolete file)

bug1448933-v2.patch
2.58 KB, patch
florian
: review+
Details | Diff | Splinter Review 
See bug 1448018.

It should do what toolkit's browser.xml does and just get it from this.frameLoader.
See Also: → 1448018
Attached patch bug1448933-v1.patch (obsolete) — — Splinter Review 
Thank you for raising this :bz!

This patch gets the doc shell from the frameLoader, similarly to browser.xml, however it is adapted to convbrowser.xml like the getter for the messageManager.
Assignee: nobody → martin
Status: NEW → ASSIGNED
Attachment #8962466 - Flags: review?(florian)
Comment on attachment 8962466 [details] [diff] [review]
bug1448933-v1.patch

Review of attachment 8962466 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/content/convbrowser.xml
@@ +86,5 @@
> +          <![CDATA[
> +            if (this._docShell) {
> +              return this._docShell;
> +            }
> +            var owner = this.QueryInterface(Ci.nsIFrameLoaderOwner);

This QI call has been removed in m-c in https://hg.mozilla.org/mozilla-central/rev/4b9198e17252#l21.1
Gets rid of the QIs for the frameLoader
Attachment #8962466 - Attachment is obsolete: true
Attachment #8962466 - Flags: review?(florian)
Attachment #8962509 - Flags: review?(florian)
Comment on attachment 8962509 [details] [diff] [review]
bug1448933-v2.patch

Review of attachment 8962509 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks good by code inspection, I haven't tried the patch locally.
Attachment #8962509 - Flags: review?(florian) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/82c2f54ceefd
Get docShell from frameLoader and don't QI for frameLoader in convbrowser.xml. r=florian
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
I don't have an Instantbird 61 target milestone, so this needs to go to Thunderbird::Instant Messaging.
Component: General → Instant Messaging
Product: Chat Core → Thunderbird
Target Milestone: --- → Thunderbird 61.0
Version: trunk → unspecified
You need to log in before you can comment on or make changes to this bug.