1448058 - Remove nsIMutable from URI implementations

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

Since URI implementations are now immutable, there is no need for objects to implement the nsIMutable interface.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1448058 - Remove nsIMutable from URI implementations

* Also removes NS_TryToMakeImmutable, NS_TryToSetImmutable, URIIsImmutable
* NS_EnsureSafeToReturn, nsINetUtil.toImmutableURI

Review commit: https://reviewboard.mozilla.org/r/242324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242324/

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8973988 [details]
Bug 1448058 - Remove nsIMutable from URI implementations

https://reviewboard.mozilla.org/r/242324/#review248554

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8973988 [details]
Bug 1448058 - Remove nsIMutable from URI implementations

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242324/diff/1-2/

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 10f2ac96468ddbaf23a3090f6441a3fb46d9743e -d bd5d3654b01e: rebasing 462834:10f2ac96468d "Bug 1448058 - Remove nsIMutable from URI implementations r=mayhemer" (tip)
merging caps/ContentPrincipal.cpp
merging chrome/nsChromeProtocolHandler.cpp
merging docshell/base/nsDocShell.cpp
merging dom/base/nsContentUtils.cpp
merging dom/base/nsDocument.cpp
merging dom/base/nsImageLoadingContent.cpp
merging dom/base/nsObjectLoadingContent.cpp
merging dom/html/nsHTMLDocument.cpp
merging netwerk/base/nsNetUtil.cpp
merging netwerk/base/nsNetUtil.h
merging netwerk/base/nsSimpleURI.cpp
merging netwerk/base/nsStandardURL.cpp
warning: conflicts while merging netwerk/base/nsNetUtil.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8973988 [details]
Bug 1448058 - Remove nsIMutable from URI implementations

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242324/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c10e876269a9
Remove nsIMutable from URI implementations r=mayhemer

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c10e876269a9