1570786 - [@ mozilla::ContentPrincipal::GetURI ] null deref

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Oriol Brufau [:Oriol]]

Open browser console and run

Cc["@mozilla.org/principal;1"].createInstance(Ci.nsIPrincipal).URI

Expected: it returns null
Actual: browser crashes (null deref)

Regression window: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=96b37ba12225d580f2b201d26915f88c5cb0d8a6&tochange=aabfe960ab59fea2e85896b1f8050786e16ab23b

Probably bug 1448058

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1570786 - Avoid ContentPrincipal::GetURI null deref r=#necko

Comment 2

[Oriol Brufau [:Oriol]]

The testcase from comment 0 does no longer work because bug 1711078 removed Cc["@mozilla.org/principal;1"].
I can still use

Cc["@mozilla.org/systemprincipal;1"].createInstance(Ci.nsIPrincipal).URI;

but that just returns null as expected.

So not sure if you patch is actually needed.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Technically true, there don't seem to be any ways of creating a contentPrincipal from JS with a null URI.
SystemPrincipal always returns a null URI.

For correctness I'd still like to land this. NS_ADDREF(*x = member) is a bad pattern anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56888fc83da3
Avoid ContentPrincipal::GetURI null deref r=necko-reviewers,kershaw

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/56888fc83da3