1448121 - Stop packaging XPT files in Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Andrew McCreight [:mccr8]]

In bug 1438688, I am removing the ability to dynamically load XPT files. Instead, XPT information will be compiled into the binary. Assuming that Thunderbird does not rely on dynamically loading XPT files (at some point Firefox addons could do that, but hopefully nobody needs that in Thunderbird?) then fixing Thunderbird should simply be a matter of removing any XPT files from files like suite/installer/package-manifest.in.

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up, I'll be watching bug 1438688. There are a heap of XPT files in the package manifests. I assume those will go from the FF package manifests, too.

Comment 2

[Richard Marti (:Paenglab)]

Yes, look at https://reviewboard.mozilla.org/r/226458/diff/2#index_header

Comment 3

[Jorg K (CEST = GMT+2)]

Bug 1438688 is on autoland for a second time. We will be busted when it is merged.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1448121-xpt.patch

First cut following
https://hg.mozilla.org/integration/autoland/rev/af6c0673ec6f

I need to check what changes are required in build/makefiles.

Comment 5

[Jorg K (CEST = GMT+2)]

I can't see anything else that needs porting, so here a try against
https://hg.mozilla.org/integration/autoland/rev/102872860c7a (from bug 1438688 comment #97):

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5aa168b44c511e8d373745ee266880e4fb0409b6

Didn't work, grr: TaskCluster error: Exception: Missing package job for docker-image-debian7-base: deb7-python3.5

Comment 6

[Jorg K (CEST = GMT+2)]

Looks like these from bug 1449629 need porting, too:
https://hg.mozilla.org/integration/autoland/rev/4b89260566da
https://hg.mozilla.org/integration/autoland/rev/87840a3dd715

Comment 7

[Jorg K (CEST = GMT+2)]

That worked:
https://hg.mozilla.org/try-comm-central/rev/9e7a0fdcee2aff56a38a038d20dfe0f534bd2c7b
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9e7a0fdcee2aff56a38a038d20dfe0f534bd2c7b

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: python3.5.patch - port bug 1449629

Unrelated but necessary.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f31b393f5f45
port bug 1438688: Stop packaging XPT files in Thunderbird. rs=bustage-fix

Comment 10

[Jorg K (CEST = GMT+2)]

Missed a few:

mail/installer/windows/nsis/installer.nsi
263 ${If} ${FileExists} "$INSTDIR\components\IKLAntiSpam.xpt"
264 Delete /REBOOTOK "$INSTDIR\components\IKLAntiSpam.xpt"
mailnews/jsaccount/test/idl/moz.build
18 '!/dist/bin/components/testJsAccount.xpt',
mailnews/jsaccount/test/unit/resources/testComponents.manifest
6 interfaces testJsAccount.xpt

Comment 11

[Jorg K (CEST = GMT+2)]

Attachment: 1448121-follow-up.patch

No idea whether this is right, let' see:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a28e1f7178860125d81909a33dd9c5675f65472

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc7cf4214dad
Follow-up: Remove references to testJsAccount.xpt. rs=bustage-fix

Comment 13

[Jorg K (CEST = GMT+2)]

Attachment: 1448121-xpt-SM.patch

FRG, I had not time this morning, but here is your patch.

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 8964684 [details] [diff] [review]
1448121-xpt-SM.patch

Never mind, you've done it already. What's the story with removed-files.in?

Comment 15

[Jorg K (CEST = GMT+2)]

Attachment: 1448121-xpt-remove-files.patch

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4753c8fcb8b6
port bug 1438688: Stop packaging XPT files, remove them from removed-files.in. rs=bustage-fix

Comment 17

[Frank-Rainer Grahl (:frg)]

> Never mind, you've done it already. 

Had some time yesterday and saw the TB patch. Thanks anway.

> What's the story with removed-files.in?

Mostly obsolete content. Upgrading from versions which used the files in it is no longer supported so this and even more can go. When I find the time I need to clean out the remaining parts for good. Usually doing the corresponding removals to package-manifest.in only. The Fx version is really really short and this is probably all which is needed for TB / SM too these days.

Comment 18

[Frank-Rainer Grahl (:frg)]

Just looked and the last file from browser\installer\removed-files.in was removed a few months ago. Only comments what the files does left.

Comment 19

[Jorg K (CEST = GMT+2)]

TB 60.5 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/20253f7096fd2fa13b90555aec110e3b17b887d4
removed-files.in patch from comment #16.