Closed
Bug 1448126
Opened 7 years ago
Closed 6 years ago
Remove scale binding and any supporting platform code
Categories
(Core :: XUL, task, P1)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: bgrins, Assigned: Paolo)
References
Details
Attachments
(2 files)
There won't be any more usages of XUL scale after it's removed from touchControls and Canvas Debugger. The binding should be removable, along with possibly XULSliderAccessible, nsISliderListener, basecontrol binding on .scale-slider, and parts of nsSliderFrame (which is still used for the xul:slider in scrollbar).
Updated•7 years ago
|
Priority: -- → P5
Comment 1•7 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P5 → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
Reporter | ||
Comment 5•6 years ago
|
||
I think there's a devtools test that will need to be updated (which uses a scale to test XBL anon content inspection): https://searchfox.org/mozilla-central/source/devtools/client/inspector/test/browser_inspector_highlighter-xbl.js#18
Reporter | ||
Comment 6•6 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #5)
> I think there's a devtools test that will need to be updated (which uses a
> scale to test XBL anon content inspection):
> https://searchfox.org/mozilla-central/source/devtools/client/inspector/test/
> browser_inspector_highlighter-xbl.js#18
Oh nevermind - looks like you already fixed that in part 1!
Reporter | ||
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8987353 [details]
Bug 1448126 - Part 1 - Remove tests for the "scale" binding.
https://reviewboard.mozilla.org/r/252596/#review259028
Attachment #8987353 -
Flags: review?(bgrinstead) → review+
Reporter | ||
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8987354 [details]
Bug 1448126 - Part 2 - Remove the "scale" binding and its supporting platform code.
https://reviewboard.mozilla.org/r/252598/#review259030
Nice cleanup! Let's wait to land this until after the merge just to be safe.
Attachment #8987354 -
Flags: review?(bgrinstead) → review+
Reporter | ||
Comment 9•6 years ago
|
||
Looks like browser_inspector_highlighter-eyedropper-xul.js is failing on the try push because it still refers to the scale - that test should be updated to select the tree instead.
Assignee | ||
Comment 10•6 years ago
|
||
Ah, I didn't notice that the "background:red" style was required by browser_inspector_highlighter-eyedropper-xul.js, even if it does nothing for the "tree" element. For some reason, removing this didn't make the test fail locally, maybe there is another color rule for the element on Mac. New tryserver build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da38ffcb7d8ca79a9f3fd79dbd79a3bae06fe046
Thanks for the quick review!
Comment 11•6 years ago
|
||
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14cc2c33cf99
Part 1 - Remove tests for the "scale" binding. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cf808cb0b0d
Part 2 - Remove the "scale" binding and its supporting platform code. r=bgrins
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/14cc2c33cf99
https://hg.mozilla.org/mozilla-central/rev/7cf808cb0b0d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•