1448126 - Remove scale binding and any supporting platform code

Status: RESOLVED FIXED

(Core :: XUL, task, P1)

Description

[Brian Grinstead [:bgrins]]

There won't be any more usages of XUL scale after it's removed from touchControls and Canvas Debugger. The binding should be removable, along with possibly  XULSliderAccessible, nsISliderListener, basecontrol binding on .scale-slider, and parts of nsSliderFrame (which is still used for the xul:slider in scrollbar).

Comment 1

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336

Comment 2

[:Paolo Amadini]

Attachment: Bug 1448126 - Part 1 - Remove tests for the "scale" binding.

Review commit: https://reviewboard.mozilla.org/r/252596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252596/

Comment 3

[:Paolo Amadini]

Attachment: Bug 1448126 - Part 2 - Remove the "scale" binding and its supporting platform code.

Review commit: https://reviewboard.mozilla.org/r/252598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252598/

Comment 4

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef64e504101006031ac88b585f38a32d86c14475

Comment 5

[Brian Grinstead [:bgrins]]

I think there's a devtools test that will need to be updated (which uses a scale to test XBL anon content inspection): https://searchfox.org/mozilla-central/source/devtools/client/inspector/test/browser_inspector_highlighter-xbl.js#18

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #5)
> I think there's a devtools test that will need to be updated (which uses a
> scale to test XBL anon content inspection):
> https://searchfox.org/mozilla-central/source/devtools/client/inspector/test/
> browser_inspector_highlighter-xbl.js#18

Oh nevermind - looks like you already fixed that in part 1!

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8987353 [details]
Bug 1448126 - Part 1 - Remove tests for the "scale" binding.

https://reviewboard.mozilla.org/r/252596/#review259028

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8987354 [details]
Bug 1448126 - Part 2 - Remove the "scale" binding and its supporting platform code.

https://reviewboard.mozilla.org/r/252598/#review259030

Nice cleanup! Let's wait to land this until after the merge just to be safe.

Comment 9

[Brian Grinstead [:bgrins]]

Looks like browser_inspector_highlighter-eyedropper-xul.js is failing on the try push because it still refers to the scale -  that test should be updated to select the tree instead.

Comment 10

[:Paolo Amadini]

Ah, I didn't notice that the "background:red" style was required by browser_inspector_highlighter-eyedropper-xul.js, even if it does nothing for the "tree" element. For some reason, removing this didn't make the test fail locally, maybe there is another color rule for the element on Mac. New tryserver build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da38ffcb7d8ca79a9f3fd79dbd79a3bae06fe046

Thanks for the quick review!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14cc2c33cf99
Part 1 - Remove tests for the "scale" binding. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cf808cb0b0d
Part 2 - Remove the "scale" binding and its supporting platform code. r=bgrins

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/14cc2c33cf99
https://hg.mozilla.org/mozilla-central/rev/7cf808cb0b0d