Remove scale binding and any supporting platform code

RESOLVED FIXED in Firefox 63

Status

()

P1
normal
RESOLVED FIXED
8 months ago
5 months ago

People

(Reporter: bgrins, Assigned: Paolo)

Tracking

(Blocks: 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 months ago
There won't be any more usages of XUL scale after it's removed from touchControls and Canvas Debugger. The binding should be removable, along with possibly  XULSliderAccessible, nsISliderListener, basecontrol binding on .scale-slider, and parts of nsSliderFrame (which is still used for the xul:slider in scrollbar).
Priority: -- → P5
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
(Assignee)

Updated

5 months ago
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P5 → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 5

5 months ago
I think there's a devtools test that will need to be updated (which uses a scale to test XBL anon content inspection): https://searchfox.org/mozilla-central/source/devtools/client/inspector/test/browser_inspector_highlighter-xbl.js#18
(Reporter)

Comment 6

5 months ago
(In reply to Brian Grinstead [:bgrins] from comment #5)
> I think there's a devtools test that will need to be updated (which uses a
> scale to test XBL anon content inspection):
> https://searchfox.org/mozilla-central/source/devtools/client/inspector/test/
> browser_inspector_highlighter-xbl.js#18

Oh nevermind - looks like you already fixed that in part 1!
(Reporter)

Comment 7

5 months ago
mozreview-review
Comment on attachment 8987353 [details]
Bug 1448126 - Part 1 - Remove tests for the "scale" binding.

https://reviewboard.mozilla.org/r/252596/#review259028
Attachment #8987353 - Flags: review?(bgrinstead) → review+
(Reporter)

Comment 8

5 months ago
mozreview-review
Comment on attachment 8987354 [details]
Bug 1448126 - Part 2 - Remove the "scale" binding and its supporting platform code.

https://reviewboard.mozilla.org/r/252598/#review259030

Nice cleanup! Let's wait to land this until after the merge just to be safe.
Attachment #8987354 - Flags: review?(bgrinstead) → review+
(Reporter)

Comment 9

5 months ago
Looks like browser_inspector_highlighter-eyedropper-xul.js is failing on the try push because it still refers to the scale -  that test should be updated to select the tree instead.
(Assignee)

Comment 10

5 months ago
Ah, I didn't notice that the "background:red" style was required by browser_inspector_highlighter-eyedropper-xul.js, even if it does nothing for the "tree" element. For some reason, removing this didn't make the test fail locally, maybe there is another color rule for the element on Mac. New tryserver build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da38ffcb7d8ca79a9f3fd79dbd79a3bae06fe046

Thanks for the quick review!

Comment 11

5 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14cc2c33cf99
Part 1 - Remove tests for the "scale" binding. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cf808cb0b0d
Part 2 - Remove the "scale" binding and its supporting platform code. r=bgrins

Comment 12

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/14cc2c33cf99
https://hg.mozilla.org/mozilla-central/rev/7cf808cb0b0d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.