1448291 - Add an option to clear all data stored by a website

Status: ASSIGNED

(DevTools :: Storage Inspector, enhancement, P2)

Description

[u614622]

Attachment: af38518a191247675dbe727e9544132ecbc2fceb_1_500x500.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180319141609

Steps to reproduce:

Open FF Web Developer Tools.
Go to Data panel.
Try to clear all data from cookies, sessionstorage, localstorage, IndexedDB etc. 
There is no “Clear storage”.



Actual results:

Every time i want to clear all site data i have to click on cookies, session storage, localstorage, IndexDB etc. and clear them separately.


Expected results:

There should be Clear storage button which clear selected data from cookies, sessionstorage, localstorage, IndexedDB etc. Something similar like in Chrome.

Comment 1

[:Harald Kirschner :digitarald]

In feature backlog

Comment 2

[rumanbsl]

Any update on this?

Comment 3

[Sebastian Zartner [:sebo]]

I guess, the easiest approach to this is to use the SiteDataManager module for this like it's done in https://searchfox.org/mozilla-central/rev/b2433a832c250c55255e0ee37d05192d04f20427/browser/base/content/pageinfo/security.js#6-8,222.

Sebastian

Comment 4

[Sebastian Zartner [:sebo]]

Attachment: Bug 1448291 - Added toolbar button to Storage Inspector that clears all data related to current website. r=ladybenko

The toolbar button calls the same logic that is used in Page Info > Security > Clear Cookies and Site Data.
That means it first fetches all hosts related to the current website's host and then opens the dialog Removing Cookies and Site Data to confirm the removal of the data.
Once the user confirms the removal, the data storages are cleared and the current view updated to reflect that the data got removed.

Comment 5

[Sebastian Zartner [:sebo]]

Note that the patch I've created doesn't include a test, unfortunately, as I don't know how to control the Removing Cookies and Site Data dialog.

Also, please let me know whether the chosen UI is ok. I've chosen to add a toolbar with the clear button above the storages because it is consistent with the other panels. And I chose to display the dialog for removal because it shows that also subdomains are affected by the deletion.

Sebastian

Comment 6

[Sebastian Zartner [:sebo]]

Attachment: Clear all storage data.png

And to show how the UI looks like with the patch applied, I've attached a screenshot.

Sebastian

Comment 7

[Sebastian Zartner [:sebo]]

As discussed with Belén, this feature has to wait until the Fission work is done and probably also the rework of the code behind the Storage Inspector. So I unassign myself for now.

Sebastian

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Also requested here:
https://connect.mozilla.org/t5/ideas/single-button-to-clear-all-site-data-in-devtools/idi-p/53788

Adding also to our weekly triage queue.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

We already support clearing each "category" individually, so we could have a button in the UI to clear everything at once

Comment 10

[jiesou]

Any updates? It's really sad to see a simple feature from 7 years ago with no progress 🥲

Comment 11

[Sebastian Zartner [:sebo]]

Attachment: Bug 1448291 - Added toolbar button to Storage Inspector that clears all data related to current website. r=#devtools-reviewers

The button added resembles the functionality offered via the "Clear cookies and site data..." option available in the address bar.

Comment 12

[Sebastian Zartner [:sebo]]

Since the Fission work is done, I rebased and updated my previous patch. It basically works the same as before, with the difference that clearing the data is now restricted to the current domain. So it basically does what the "Clear cookies and site data..." option in the address bar does.

As the Storage Inspector is still based on XUL, I didn't have to change the patch much. Though see also the discussion in https://phabricator.services.mozilla.com/D105122.

The patch still doesn't have a test case, unfortunately.

Sebastian