1448309 - Some restored history entries don't load

Status: RESOLVED DUPLICATE of bug 1452666

(Firefox :: Session Restore, defect, P1)

Description

[Kusanagi Kouichi]

Attachment: sessionstore.jsonlz4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180219150722

Steps to reproduce:

1. Copy the attatched sessionstore.jsonlz4 to a profile
2. Restore session
3. Go forward
4. Go back


Actual results:

The restored tab doesn't load and can't go back.

Console:
Given tab is not restoring.  SessionStore.jsm:4727
        _resetLocalTabRestoringState resource:///modules/sessionstore/SessionStore.jsm:4727:7
        receiveMessage resource:///modules/sessionstore/SessionStore.jsm:984:9
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.goBack]  browser-child.js:323


Expected results:

The restored tab loads and can go back.

Comment 1

[Kusanagi Kouichi]

Firefox 58 works as expected. Bug 1345433 seems relevant.

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]: possible data loss

I can reproduce on Nightly61.0a1 window10 64bit as well.

regression window:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2a5765cbd308215f11ea6bc7b52e71228709d971&tochange=166fb0b613592e18893c0d825dd5332c6185b2ce


:ckerschb, (:tnguyen is not available)
Your bunch of patch seems to cause the regression, can you look into this?

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Jonathan, this falls in line with the triggeringPrincipal work you are doing. Can you please prioritize this one and take a look?

Comment 4

[Jonathan Kingston [:jkt] he/him]

I can replicate this, is there any advice on how to replicate without the backup?

Comment 5

[Jim Mathies [:jimm]]

checking back in  on this.

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Jim Mathies [:jimm] from comment #5)
> checking back in  on this.

:jkt, were you able to make any progress on this one?

Comment 8

[Jonathan Kingston [:jkt] he/him]

I wasn't able to repro however Ryan found an STR in Bug 1449301 which really should help. I was able to repro those steps on a brand new profile.

Comment 9

[Jonathan Kingston [:jkt] he/him]

In a debug build I am getting the following error on closing the tab:

Utils: Failed to serialize principal '[xpconnect wrapped nsIPrincipal @ 0x55b026646420 (native @ 0x55b02669a518)]' [Exception... "Could not convert JavaScript argument arg 0 [nsISerializationHelper.serializeToString]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: resource://gre/modules/sessionstore/Utils.jsm :: serializePrincipal :: line 125" data: no]

I think this is likely the actual error causing as the session restore code deserialises the triggering principal to use.

Comment 10

[Jonathan Kingston [:jkt] he/him]

Even though this was likely caused by not being able to serialize an expanded principal. I think we shouldn't attempt to fix broken histories here and wontfix this one. If we fix the root cause we shouldn't ever see this and require code for fixing up principals.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Moving the tracking flags over to bug 1452666 instead of this bug.