1449301 - Tabs sometimes restored as blank when trying to undo close tab with Ctrl+Shift+T

Status: VERIFIED DUPLICATE of bug 1452666

(Firefox :: Session Restore, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

Sometimes when I try to undo closing a tab with Ctrl+Shift+T, the tab is restored blank. Reloading doesn't do anything, but highlighting the URL bar and hitting enter loads the page. I've been seeing this intermittently for awhile now, but haven't been able to narrow down any sort of solid STR for the problem. Just seems to happen randomly from time to time.

Comment 1

[Mike de Boer [:mikedeboer]]

Will become P1 with STR!

Comment 2

[Ryan VanderMeulen [:RyanVM]]

jcristau astutely pointed out on IRC that this seems to be tied to tabs opened via the "Open All in Tabs" option added to bug query results via the "BugzillaJS: Open all in Tabs" extension. Mike, does that help you reproduce?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

In fact, with those STR, I was even able to bisect this with mozregression!

INFO: Last good revision: 2a5765cbd308215f11ea6bc7b52e71228709d971
INFO: First bad revision: 166fb0b613592e18893c0d825dd5332c6185b2ce
INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2a5765cbd308215f11ea6bc7b52e71228709d971&tochange=166fb0b613592e18893c0d825dd5332c6185b2ce

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: the serach results link in question

Link to the extension:
https://addons.mozilla.org/firefox/addon/bugzillajs-open-all-in-tabs/

Comment 5

[Ryan VanderMeulen [:RyanVM]]

...which is conveniently the same culprit as bug 1448309.

Comment 6

[Mike de Boer [:mikedeboer]]

Ryan, you're badass! Thanks for helping out and finding the regression!

Comment 7

[Jonathan Kingston [:jkt] he/him]

Amazing I can STR this consistently:

1. Install https://addons.mozilla.org/en-GB/firefox/addon/bugzillajs-open-all-in-tabs/
2. Go to https://bugzilla.mozilla.org/buglist.cgi?quicksearch=strange+thing
3. Click "Open All in Tabs"
4. Click next tab along
5. Ctrl+w
6. Ctrl+Shift+T

I get the following error:
"Given tab is not restoring. SessionStore.jsm:4839"

I think this is a duplicate of bug 1448309 based on that. I'm happy to leave open or whatever work.

Comment 8

[Jonathan Kingston [:jkt] he/him]

It appears the content script is creating the tabs with expanded principals which are not serialisable. I suspect we should pick the last principal in the list perhaps.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Verified working correctly on current nightly now.