Open Bug 1448423 Opened 2 years ago Updated 6 months ago

browser.startup.blankWindow bugs when privacy.resistFingerprinting is enabled

Categories

(Firefox :: General, defect, P3)

61 Branch
x86_64
Linux
defect

Tracking

()

Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- fix-optional

People

(Reporter: ahx27k+c4n0glofdot50, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20100101

Steps to reproduce:

Run latest Nightly, enable privacy.resistFingerprinting, and close then open the browser.


Actual results:

The window gets maximized then minimized again.


Expected results:

The window shouldn't be maximized in the first place.
Blocks: 1447719
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Component: Untriaged → General
Hey Tom, Is this shipping in 61?
Flags: needinfo?(tom)
(In reply to Marion Daly [:mdaly] from comment #1)
> Hey Tom, Is this shipping in 61?

Resist Fingerprinting is a non-default preference; it is present in 61, but it is not on by default.
Flags: needinfo?(tom)
Making it a fix-optional for 61 then.
I might have reproduced this?  Ubuntu 17.10 x64

Enable RFP
Maximize the window
Close Firefox
Open Firefox
It opens maximized, then visibly resizes to rounded dimension

Also:
Enable RFP
Resize Window to be non-maximized but slightly larger than rounded dimensions
Close Firefox
Open Firefox
It opens at the previous size then visibly resizes to rounded dimensions


If I disable browser.startup.blankWindow then the window will _start_ with the same resized dimensions as before, instead of visibly resizing in front of me.

So something in browser.startup.blankWindow definitely is affecting this.  But the resulting resized behavior I think is what we intended? Want to double check with Arthur.
Flags: needinfo?(arthuredelstein)
I think ideally, on startup, the window should open directly to the RFP dimensions, without any visible resizing.
Flags: needinfo?(arthuredelstein)
Priority: -- → P3
(In reply to Tom Ritter [:tjr] from comment #4)

> So something in browser.startup.blankWindow definitely is affecting this.

Yes, see https://searchfox.org/mozilla-central/rev/7e663b9fa578d425684ce2560e5fa2464f504b34/browser/components/nsBrowserGlue.js#52-65

(In reply to Arthur Edelstein (Tor Browser dev) [:arthuredelstein] from comment #5)
> I think ideally, on startup, the window should open directly to the RFP
> dimensions, without any visible resizing.

Right, so I think the question is why are the sizemode, width and height set by RFP not persisted in XULStore.
Blocks: 1336227
No longer blocks: 1447719
See Also: → 1535565
See Also: → 1535568
No longer blocks: 1336227
Regressed by: 1336227
You need to log in before you can comment on or make changes to this bug.