Closed
Bug 1448453
Opened 7 years ago
Closed 7 years ago
libvpx needs a MingGW x64 config
Categories
(Core :: Audio/Video: Playback, enhancement)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla61
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
kinetik
:
review+
jcristau
:
approval-mozilla-esr60+
|
Details |
Otherwise we get errors like
> /builds/worker/workspace/build/src/media/libvpx/libvpx/vp8/common/findnearmv.h:24:1: error: multiple storage classes in declaration specifiers
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Component: Audio/Video → Audio/Video: Playback
Assignee | ||
Updated•7 years ago
|
Attachment #8961931 -
Flags: review?(cpearce)
Updated•7 years ago
|
Attachment #8961931 -
Flags: review?(cpearce) → review?(kinetik)
Comment 2•7 years ago
|
||
Similar to Bug 1448461, I a not the right person to review this, passing to kinetik.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8961931 [details]
Bug 1448453 Update libvpx to have a 64 bit mingw config
https://reviewboard.mozilla.org/r/230762/#review237258
Attachment #8961931 -
Flags: review?(kinetik) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c5f36025672
Update libvpx to have a 64 bit mingw config r=kinetik
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8961931 [details]
Bug 1448453 Update libvpx to have a 64 bit mingw config
[Approval Request Comment]
This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.
This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8961931 -
Flags: approval-mozilla-esr60?
Comment 7•6 years ago
|
||
Comment on attachment 8961931 [details]
Bug 1448453 Update libvpx to have a 64 bit mingw config
mingw build fix, approved for 60.1esr
Attachment #8961931 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Comment 8•6 years ago
|
||
bugherder uplift |
status-firefox-esr60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•