1448453 - libvpx needs a MingGW x64 config

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Tom Ritter [:tjr]]

Otherwise we get errors like

> /builds/worker/workspace/build/src/media/libvpx/libvpx/vp8/common/findnearmv.h:24:1: error: multiple storage classes in declaration specifiers

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1448453 Update libvpx to have a 64 bit mingw config

Review commit: https://reviewboard.mozilla.org/r/230762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230762/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Similar to Bug 1448461, I a not the right person to review this, passing to kinetik.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8961931 [details]
Bug 1448453 Update libvpx to have a 64 bit mingw config

https://reviewboard.mozilla.org/r/230762/#review237258

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c5f36025672
Update libvpx to have a 64 bit mingw config r=kinetik

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5c5f36025672

Comment 6

[Tom Ritter [:tjr]]

Comment on attachment 8961931 [details]
Bug 1448453 Update libvpx to have a 64 bit mingw config

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8961931 [details]
Bug 1448453 Update libvpx to have a 64 bit mingw config

mingw build fix, approved for 60.1esr

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/38cda0a09c9d