1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title

Status: RESOLVED FIXED

(Firefox :: Private Browsing, enhancement)

Description

[Dão Gottwald [:dao]]

The only case tabbrowser doesn't handle is about:privatebrowsing in a non-private window. But we don't expose the about:privatebrowsing URL anywhere in the UI, so I think we can do without that special title (which doesn't seem too useful anyway).

I think we'll want to do the same for about:newtab but it looks like this will need to happen on github.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=99355ed04b8f370c732b92bf08e4f30d917df739

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title.

Review commit: https://reviewboard.mozilla.org/r/230796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230796/

Comment 2

[:Gijs (out for now; he/him)]

(In reply to Dão Gottwald [::dao] from comment #0)
> I think we'll want to do the same for about:newtab but it looks like this
> will need to happen on github.

My understanding is that we tried this (removing the in-page <title> for about:newtab) before and it caused race conditions where the tab ended up without an icon and/or title. See https://github.com/mozilla/activity-stream/pull/3922 and bug 1423256. I haven't looked into it in detail, but are we sure that case won't apply here, and/or to about:newtab anymore?

Comment 3

[Dão Gottwald [:dao]]

(In reply to :Gijs (out until 26th) from comment #2)
> (In reply to Dão Gottwald [::dao] from comment #0)
> > I think we'll want to do the same for about:newtab but it looks like this
> > will need to happen on github.
> 
> My understanding is that we tried this (removing the in-page <title> for
> about:newtab) before and it caused race conditions where the tab ended up
> without an icon and/or title. See
> https://github.com/mozilla/activity-stream/pull/3922 and bug 1423256. I
> haven't looked into it in detail, but are we sure that case won't apply
> here, and/or to about:newtab anymore?

I (mis?)remembered that bug 1427186 was about the icon rather than the title. But that was also prior to bug 1427186, so maybe it's not an issue anymore. Needs a closer look. In any case, this shouldn't apply to private windows as we don't restore those.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #3)
> But that was also prior to bug 1427186, so maybe it's not an issue
> anymore. Needs a closer look.

Or maybe not. Bug 1427186 didn't really change anything for non-private windows.

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8961954 [details]
Bug 1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title.

https://reviewboard.mozilla.org/r/230796/#review237058

Some of the dupes of that bug also talk about duplicate tab (bug 1426916) and some other stuff that doesn't apply to about:privatebrowsing. I verified duplicating private tabs doesn't cause issues with this patch applied. Navigating to about:privatebrowsing manually in a non-private window shows the URL, which I guess is fine.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49867cc4dcc2
Remove <title> element from about:privatebrowsing since tabbrowser already sets the title. r=Gijs

Comment 7

[Eliza Balazs [:ebalazs_]]

Backed out changeset 49867cc4dcc2 (bug 1448482) for ss failures in browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js
push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=49867cc4dcc2b2a9f74e52f839348717cbd96b00&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success&filter-resultStatus=retry&filter-resultStatus=running&filter-resultStatus=pending&selectedJob=170587677
failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=170587677&repo=autoland
backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=83d26371b1a589384141aaad77873b819df88c83&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success&filter-resultStatus=retry&filter-resultStatus=running&filter-resultStatus=pending

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8961954 [details]
Bug 1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230796/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aff5461074b6
Remove <title> element from about:privatebrowsing since tabbrowser already sets the title. r=Gijs

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aff5461074b6