Remove <title> element from about:privatebrowsing since tabbrowser already sets the title

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
The only case tabbrowser doesn't handle is about:privatebrowsing in a non-private window. But we don't expose the about:privatebrowsing URL anywhere in the UI, so I think we can do without that special title (which doesn't seem too useful anyway).

I think we'll want to do the same for about:newtab but it looks like this will need to happen on github.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=99355ed04b8f370c732b92bf08e4f30d917df739

Comment 2

a year ago
(In reply to Dão Gottwald [::dao] from comment #0)
> I think we'll want to do the same for about:newtab but it looks like this
> will need to happen on github.

My understanding is that we tried this (removing the in-page <title> for about:newtab) before and it caused race conditions where the tab ended up without an icon and/or title. See https://github.com/mozilla/activity-stream/pull/3922 and bug 1423256. I haven't looked into it in detail, but are we sure that case won't apply here, and/or to about:newtab anymore?
Flags: needinfo?(dao+bmo)
Assignee

Comment 3

a year ago
(In reply to :Gijs (out until 26th) from comment #2)
> (In reply to Dão Gottwald [::dao] from comment #0)
> > I think we'll want to do the same for about:newtab but it looks like this
> > will need to happen on github.
> 
> My understanding is that we tried this (removing the in-page <title> for
> about:newtab) before and it caused race conditions where the tab ended up
> without an icon and/or title. See
> https://github.com/mozilla/activity-stream/pull/3922 and bug 1423256. I
> haven't looked into it in detail, but are we sure that case won't apply
> here, and/or to about:newtab anymore?

I (mis?)remembered that bug 1427186 was about the icon rather than the title. But that was also prior to bug 1427186, so maybe it's not an issue anymore. Needs a closer look. In any case, this shouldn't apply to private windows as we don't restore those.
Flags: needinfo?(dao+bmo)
Assignee

Comment 4

a year ago
(In reply to Dão Gottwald [::dao] from comment #3)
> But that was also prior to bug 1427186, so maybe it's not an issue
> anymore. Needs a closer look.

Or maybe not. Bug 1427186 didn't really change anything for non-private windows.

Comment 5

a year ago
mozreview-review
Comment on attachment 8961954 [details]
Bug 1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title.

https://reviewboard.mozilla.org/r/230796/#review237058

Some of the dupes of that bug also talk about duplicate tab (bug 1426916) and some other stuff that doesn't apply to about:privatebrowsing. I verified duplicating private tabs doesn't cause issues with this patch applied. Navigating to about:privatebrowsing manually in a non-private window shows the URL, which I guess is fine.
Attachment #8961954 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 6

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49867cc4dcc2
Remove <title> element from about:privatebrowsing since tabbrowser already sets the title. r=Gijs
Comment hidden (mozreview-request)
Assignee

Updated

a year ago
Flags: needinfo?(dao+bmo)

Comment 9

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aff5461074b6
Remove <title> element from about:privatebrowsing since tabbrowser already sets the title. r=Gijs

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aff5461074b6
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.