1448526 - ComputedStyle::sDependencyTable and its friends can be removed

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+11]

The dependency table was initially introduced in bug 1122781 to detect cycle dependencies between style structs with a combination of runtime and build time check.

It is no longer necessary as Servo uses early / other category to resolve dependencies between properties rather than nested invoking style struct computation.

Specifically ComputedStyle::sDependencyTable and the code to generate it in generate-stylestructlist.py can be removed.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1448526 part 1 - Remove ComputedStyle::sDependencyTable.

Review commit: https://reviewboard.mozilla.org/r/231090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231090/

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1448526 part 2 - Make nsStyleStructList.h not generated.

nsStyleStructList.h was initially made generated in bug 873368 to avoid
manually maintaining boilerplate for if-dispatch, while the if-dispatch
was replaced by jump table in bug 1171842, so the boilerplate went away.

However, in bug 1122781 (before bug 1171842), boilerplate for dependency
check, so it still needs to be generated.

The dependency table is removed in the previous patch, so we no longer
have any boilerplate in the style struct list, and thus it doesn't need
to be generated anymore.

Review commit: https://reviewboard.mozilla.org/r/231092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231092/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8962241 [details]
Bug 1448526 part 1 - Remove ComputedStyle::sDependencyTable.

https://reviewboard.mozilla.org/r/231090/#review236508

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8962242 [details]
Bug 1448526 part 2 - Make nsStyleStructList.h not generated.

https://reviewboard.mozilla.org/r/231092/#review236510

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s dee4e0909c1d60cc071d90cd97cd5a2a9561aec0 -d 868bd92df11a: rebasing 453998:dee4e0909c1d "Bug 1448526 part 1 - Remove ComputedStyle::sDependencyTable. r=emilio"
merging layout/style/ComputedStyle.cpp
merging layout/style/ComputedStyle.h
rebasing 453999:1f3661ae0e8b "Bug 1448526 part 2 - Make nsStyleStructList.h not generated. r=emilio" (tip)
merging dom/base/nsWindowMemoryReporter.cpp
merging dom/base/nsWindowSizes.h
merging layout/style/ComputedStyle.cpp
merging layout/style/ComputedStyle.h
merging layout/style/ServoBindings.cpp
merging layout/style/nsComputedDOMStyle.h
merging layout/style/nsStyleStruct.cpp
warning: conflicts while merging dom/base/nsWindowMemoryReporter.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/338d12d53540
part 1 - Remove ComputedStyle::sDependencyTable. r=emilio
https://hg.mozilla.org/integration/autoland/rev/5767653abf86
part 2 - Make nsStyleStructList.h not generated. r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aadba8230c95
followup: Fix remaining macro declaration on a CLOSED TREE. r=me

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4c5d4aba912
followup: Fix remaining macro declaration on a CLOSED TREE. r=me

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/338d12d53540
https://hg.mozilla.org/mozilla-central/rev/5767653abf86
https://hg.mozilla.org/mozilla-central/rev/aadba8230c95
https://hg.mozilla.org/mozilla-central/rev/f4c5d4aba912