1448627 - Crash in MixerContext::MixerContext

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

This bug was filed from the Socorro interface and is
report bp-7d99db16-37e8-4c5f-a493-04e320180325.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll MixerContext::MixerContext media/libcubeb/src/cubeb_mixer.cpp:105
1 xul.dll cubeb_mixer_create media/libcubeb/src/cubeb_mixer.cpp:645
2 xul.dll static int `anonymous namespace'::setup_wasapi_stream media/libcubeb/src/cubeb_wasapi.cpp:1745
3 xul.dll static int `anonymous namespace'::wasapi_stream_init media/libcubeb/src/cubeb_wasapi.cpp:1834
4 xul.dll cubeb_stream_init media/libcubeb/src/cubeb.c:315
5 xul.dll mozilla::AudioStream::OpenCubeb dom/media/AudioStream.cpp:386
6 xul.dll mozilla::AudioStream::Init dom/media/AudioStream.cpp:370
7 xul.dll mozilla::media::AudioSink::InitializeAudioStream dom/media/mediasink/AudioSink.cpp:204
8 xul.dll mozilla::media::AudioSink::Init dom/media/mediasink/AudioSink.cpp:95
9 xul.dll mozilla::media::AudioSinkWrapper::Start dom/media/mediasink/AudioSinkWrapper.cpp:196

=============================================================

Reproducible: always

Steps To Reproduce:
1. Open https://www.youtube.com/watch?v=zOWJqNPeifU

Actual Results:
Tab crashes

Comment 1

[Alice0775 White]

Attachment: about:support

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2acdab79292680b9764ad907d4ca67f9aa8bb49d&tochange=8d4c3cf648d6a9eecb8939df9c4f868570561ec8

Suspect: Bug 1432779

@:jya
Your bunch of patch seems to cause the crash, can you look into this?

Comment 4

[Ekanan Ketunuti]

cp'ing from bug 1448628

STR: 

Load https://sinjidon.tumblr.com/post/163696633377 and play video
or https://vtt.tumblr.com/tumblr_ou15s1RDoW1vgmqck.mp4

Comment 5

[Jean-Yves Avenard [:jya]]

(In reply to Alice0775 White from comment #2)
> Regression window:
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=2acdab79292680b9764ad907d4ca67f9aa8bb49d&tochange=8d4c
> 3cf648d6a9eecb8939df9c4f868570561ec8
> 
> Suspect: Bug 1432779
> 
> @:jya
> Your bunch of patch seems to cause the crash, can you look into this?

it works for me, (be certain I had extensively tested youtube !)

what is your speaker configuration on your PC?

removing preferred channel layout may not have been such a good idea after all, it only makes it harder to diagnostic the issue now as it would have provided me that answer...

Comment 6

[Alice0775 White]

Attachment: audio.png

(In reply to Jean-Yves Avenard [:jya] from comment #5)
> 
> what is your speaker configuration on your PC?
> 

I do not know what you need. But, I attached a screenshot about sound properties.

Comment 7

[Jean-Yves Avenard [:jya]]

The issue is that you're using a Core 2 Duo or earlier I think... it doesn't have one instruction we use.

Comment 8

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1448627 - Don't use __popcnt intrinsec on windows.

Not all processors support it.

Review commit: https://reviewboard.mozilla.org/r/230980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230980/

Comment 9

[Paul Adenot (:padenot)]

Attachment: Bug 1448627 - Update cubeb to 7712aaab.

Review commit: https://reviewboard.mozilla.org/r/230984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230984/

Comment 10

[Paul Adenot (:padenot)]

Comment on attachment 8962136 [details]
Bug 1448627 - Don't use __popcnt intrinsec on windows.

https://reviewboard.mozilla.org/r/230980/#review236416

We'll merge the other patch.

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8962136 [details]
Bug 1448627 - Don't use __popcnt intrinsec on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230980/diff/1-2/

Comment 12

[Paul Adenot (:padenot)]

Comment on attachment 8962136 [details]
Bug 1448627 - Don't use __popcnt intrinsec on windows.

https://reviewboard.mozilla.org/r/230980/#review236418

Comment 13

[Jean-Yves Avenard [:jya]]

Comment on attachment 8962137 [details]
Bug 1448627 - Update cubeb to 7712aaab.

https://reviewboard.mozilla.org/r/230984/#review236420

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc799615ea60
Update cubeb to 7712aaab. r=jya

Comment 15

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/cc799615ea60

Comment 16

[Jean-Yves Avenard [:jya]]

Alice, could you check that the latest nightly fixes the problem for you?

thank you

Comment 17

[Alice0775 White]

(In reply to Jean-Yves Avenard [:jya] from comment #16)
> Alice, could you check that the latest nightly fixes the problem for you?
> 
> thank you

Latest Nightly61.0a1[1] is no longer crashed.

[1]
Build ID 	20180325130758
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Built from https://hg.mozilla.org/mozilla-central/rev/0707db8f028da5515484a24912b530491d918c3b