1448719 - Trunk: Smileys in chat don't work any more

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Jorg K (CEST = GMT+2)]

I've noticed that in today's TaskCluster build, smileys in chat don't work any more.

STR:
Connect to chat, for instance #maildev on irc.mozilla.org and type :-) or :) and hit enter.

That text should be replaced by a smiley but isn't.

Maybe bug 1445396 is at fault which landed on 19-Mar-2018. I think the Daily of the day still had the smileys.

Alice, would you be so kind and assist us here again.

Comment 1

[Alice0775 White]

regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=2dc101e7eddc3ebfc0e470f4d4a53b40cefff464&tochange=3ab4909ae468036fc28de5031dd6595db1364b53
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bfb7edfd0436db388bb9e103b8ad817fc50bfdcf&tochange=827c686c570935483c3ad8022aa92b9e005574c3

suspect:
377b62a130e7	Valentin Gosu — Bug 1442239 - Fix test since nsSimpleURI can't be constructed via createInstance() anymore r=Waldo
61aa0247279a	Valentin Gosu — Bug 1442239 - Make URI deserialization (nsISerializable.read) happen via nsIURIMutator only r=mayhemer

Comment 2

[Alice0775 White]

Error console shows

TypeError: Cc['@mozilla.org/network/simple-uri;1'] is undefined[Learn More]
smileProtocolHandler.js:21:9

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks Alice, much appreciated. Yes, another fallout from the URI changes and very easy to fix ;-)
The initialisation via |.createInstance(Ci.nsIURI);| doesn't work any more.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1448719-mutator.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/579bea71fa70
Bug 1447272 follow-up: Replace createInstance(Ci.nsIURI) with mutator. r=me

Comment 6

[:aceman]

Comment on attachment 8962273 [details] [diff] [review]
1448719-mutator.patch

Review of attachment 8962273 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, works for me.