1448728 - Clean up items in memory report for the old style system

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1448728 part 1 - Make popular headers not include nsWindowSizes.h.

Review commit: https://reviewboard.mozilla.org/r/231066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231066/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1448728 part 2 - Remove style sizes for the old style system from nsWindowSizes.h.

Review commit: https://reviewboard.mozilla.org/r/231074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231074/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1448728 part 3 - Remove mention of servo in memory report as it's the only style system now.

Review commit: https://reviewboard.mozilla.org/r/231076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231076/

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8962235 [details]
Bug 1448728 part 1 - Make popular headers not include nsWindowSizes.h.

https://reviewboard.mozilla.org/r/231066/#review236484

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 8962236 [details]
Bug 1448728 part 2 - Remove style sizes for the old style system from nsWindowSizes.h.

https://reviewboard.mozilla.org/r/231074/#review236486

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 8962237 [details]
Bug 1448728 part 3 - Remove mention of servo in memory report as it's the only style system now.

https://reviewboard.mozilla.org/r/231076/#review236488

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e32869c39038
part 0 - Remove objects only used in the old style system from nsPresArena::AddSizeOfExcludingThis. r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/420e6f921109
part 1 - Make popular headers not include nsWindowSizes.h. r=njn
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fef911c5571
part 2 - Remove style sizes for the old style system from nsWindowSizes.h. r=njn
https://hg.mozilla.org/integration/mozilla-inbound/rev/15226faf0444
part 3 - Remove mention of servo in memory report as it's the only style system now. r=njn

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09df78447c1a
followup - Move ServoComputedValuesMallocEnclosingSizeOf to ComputedStyle.cpp.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2813cc474565
followup 2 - Remove style structs from nsPresArena::AddSizeOfExcludingThis on a CLOSED TREE. r=emilio

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e32869c39038
https://hg.mozilla.org/mozilla-central/rev/420e6f921109
https://hg.mozilla.org/mozilla-central/rev/6fef911c5571
https://hg.mozilla.org/mozilla-central/rev/15226faf0444
https://hg.mozilla.org/mozilla-central/rev/09df78447c1a
https://hg.mozilla.org/mozilla-central/rev/2813cc474565