1448922 - GeckoProfiler.cpp has a stale link to cleopatra/js/parserWorker.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[André Bargull [:anba]]

js/src/vm/GeckoProfiler.cpp contains this comment [1]:

> // Note: this profiler string is regexp-matched by
> // devtools/client/profiler/cleopatra/js/parserWorker.js.

Does this comment still apply and if it does, can it be updated to reflect the new file name?

[1] https://searchfox.org/mozilla-central/rev/003262ae12ce937950ffb8d3b0fa520d1cc38bff/js/src/vm/GeckoProfiler.cpp#285-286

Comment 1

[Jason Orendorff [:jorendorff]]

jryans, do you know?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Although I did update that line most recently, it was based on a script for DevTools paths, so the comment might have already been outdated even then...  Let's see though.

`parserWorker.js` first appeared in bug 795268 on 2012-12-15.  The comment in question was first added by bug 895015 on 2013-07-17.  On 2014-08-06, bug 879008 removed[1] the "old profiler UI" including `parserWorker.js`.  (So indeed, the file was already gone when my script updated this comment on 2015-09-21.)

So, the file in question no longer exists, but it's possible the perf.html UI makes a similar assumption for this function...?  I am not sure though, so let's ask :mstange about that.

[1]: https://hg.mozilla.org/mozilla-central/rev/d6ea14edc3d4

Comment 3

[Markus Stange [:mstange]]

The correct filename is devtools/client/performance/modules/logic/frame-utils.js:
https://searchfox.org/mozilla-central/rev/028cd8342899357d80fafba2d528a0fd5819e316/devtools/client/performance/modules/logic/frame-utils.js#48

There's also code in perf.html that expects this string format:
https://github.com/devtools-html/perf.html/blob/9685e0ab9c2dd7f5a608f0e96b71d3ef43df6671/src/profile-logic/process-profile.js#L380

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1448922 - Update comment about profiler parsing r?canaltinova DONTBUILD

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c12aea0d681e
Update comment about profiler parsing r=canaltinova DONTBUILD

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/c12aea0d681e