1448992 - Get rid of nsXPCComponentsBase

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

It's unused once bug 1389581 is fixed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Get rid of nsXPCComponentsBase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8962506 [details] [diff] [review]
Get rid of nsXPCComponentsBase

This isn't right yet.

Comment 3

[Boris Zbarsky [:bzbarsky]]

My patch for this makes layout/reftests/bugs/498228-1.xul fail.

The reason for that is that in toolkit/content/widgets/listbox.xml in the "control" getter of the "listitem" binding we have:

  if (parent instanceof Ci.nsIDOMXULSelectControlElement)

and that throws with this patch (because there is no more Ci in the content XBL scope).

Brian, do we have a plan yet for those nsIDOMXUL* interfaces implemented via XBL implements=""?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #3)
> My patch for this makes layout/reftests/bugs/498228-1.xul fail.
> 
> The reason for that is that in toolkit/content/widgets/listbox.xml in the
> "control" getter of the "listitem" binding we have:
> 
>   if (parent instanceof Ci.nsIDOMXULSelectControlElement)
> 
> and that throws with this patch (because there is no more Ci in the content
> XBL scope).
> 
> Brian, do we have a plan yet for those nsIDOMXUL* interfaces implemented via
> XBL implements=""?

Yes, Neil is trying out two different approaches for [implements] in Bug 1446961. Forwarding ni? to see if they might work for nsIDOMXULSelectControlElement. I also wonder if in practice this getter is only ever called in certain scenarios, such that we could change the instanceof check into a tag name check or look for some own property like `getIndexOfItem` or something like that.

Comment 5

[Brian Grinstead [:bgrins]]

This pattern looks to be used in a few other places, but is pretty infrequent overall: https://searchfox.org/mozilla-central/search?q=instanceof+Ci.&case=true&path=xml

Comment 6

[Neil Deakin]

In this case, the code could be changed to look for specific tags rather than the interface. Note also that the methods are inherited so it will need to deal with both listbox and richlistbox related tags.

Although the work in bug 1446961 could handle some specific cases, it won't be able to handle most of the interface usage. I think you will still have some cases where methods implemented in script will be needed.

Comment 7

[Boris Zbarsky [:bzbarsky]]

I know I can use specific tags here.  I was trying to figure out whether there is something else that would be better based on what we plan to do to replace nsIDOMXULSelectControlElement.

Comment 8

[Brian Grinstead [:bgrins]]

I remember you mentioned that we can't right now have a Custom Element use QueryInterface: https://bugzilla.mozilla.org/show_bug.cgi?id=1404420#c15. Is that something that we could change to make `this.QueryInterface` work on DOM nodes, or store some metadata about the interface into the Custom Element registration? That would make migration easier.. but are there downsides to that approach?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Sorry, I had thought this was a self-needinfo...

Brian, is the question in comment 8 still relevant given our current plans for custom elements implementing interfaces?

Comment 10

[Brian Grinstead [:bgrins]]

(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #9)
> Sorry, I had thought this was a self-needinfo...
> 
> Brian, is the question in comment 8 still relevant given our current plans
> for custom elements implementing interfaces?

No, this is now possible as of Bug 1478372. Going to ship the first CE using this in Bug 1481949.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1448992. Get rid of nsXPCComponentsBase.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6f02d0b050d
Get rid of nsXPCComponentsBase. r=bholley

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f6f02d0b050d