Convert <radiogroup> to a Custom Element

RESOLVED FIXED in Firefox 64

Status

()

P3
normal
RESOLVED FIXED
8 months ago
2 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Depends on: 1 bug, Blocks: 3 bugs)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

8 months ago
Once we can implement nsIDOMXULSelectControlElement and nsIDOMXULControlElement (Bug 1478372), this looks like a relatively simple binding to convert:

- https://bgrins.github.io/xbl-analysis/tree/#radiogroup
- Used features: resources (1), property (6), field (1), handler (8), method (6), constructor (1)
- Selectors: radiogroup (content/xul.css)
(Assignee)

Updated

8 months ago
Component: XUL → XUL Widgets
Product: Core → Toolkit
Priority: -- → P3
(Assignee)

Comment 1

6 months ago
Comment on attachment 9010439 [details]
Bug 1481949 - Migrate <radiogroup> to a Custom Element;r=timdream

Tim Guan-tin Chien [:timdream] (please needinfo) has approved the revision.
Attachment #9010439 - Flags: review+
Attachment #9010438 - Attachment is obsolete: true
(Assignee)

Updated

6 months ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
(Assignee)

Comment 4

6 months ago
They are unnecessary for most every element, and we load multiple dummy.xul
documents even in clean profiles.
Comment on attachment 9012656 [details]
Bug 1481949 - Don't load Custom Element script files for dummy.xul windows;r=kmag

Kris Maglione [:kmag] has approved the revision.
Attachment #9012656 - Flags: review+
(Assignee)

Updated

6 months ago
Blocks: 1495252
(Assignee)

Comment 6

6 months ago
This removes support for having a child radiogroup within another radiogroup, but that
behavior is undocumented and unused in tree.
Comment on attachment 9013176 [details]
Bug 1481949 - Use querySelectorAll instead of a treeWalker for finding radios underneath a radiogroup;r=timdream

Tim Guan-tin Chien [:timdream] (please needinfo) has approved the revision.
Attachment #9013176 - Flags: review+

Comment 8

6 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96cb7281e630
Don't load Custom Element script files for dummy.xul windows;r=kmag
https://hg.mozilla.org/integration/autoland/rev/b82060ff3299
Migrate <radiogroup> to a Custom Element;r=timdream
https://hg.mozilla.org/integration/autoland/rev/05e791fb2c6b
Use querySelectorAll instead of a treeWalker for finding radios underneath a radiogroup;r=timdream

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/96cb7281e630
https://hg.mozilla.org/mozilla-central/rev/b82060ff3299
https://hg.mozilla.org/mozilla-central/rev/05e791fb2c6b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
(Assignee)

Updated

6 months ago
Blocks: 1495861
Depends on: 1495946
Depends on: 1517101
You need to log in before you can comment on or make changes to this bug.