1449009 - Non-localized strings on Customize -> Themes dropdown, if any theme but 'Default' is selected

Status: RESOLVED DUPLICATE of bug 658044

(Firefox :: Toolbars and Customization, defect)

Description

[Itiel]

STR:
1. Use any non-english build of Nightly
2. Open the customization page
3. Click 'Themes'
4. Select 'Dark' for exaple
5. Click 'Themes' again

AR:
The 'Default' text and its tooltip are now back to English.

ER:
Both should remain in the localized versions. Reverting back to Default fixes this.

Comment 1

[:Gijs (he/him)]

Is this a regression, or has it always been broken?

Off-hand, I don't understand how/why this would happen - we always get the theme name off the theme object, here:

https://dxr.mozilla.org/mozilla-central/rev/de32269720d056972b85f4eec5f0a8286de6e3af/browser/components/customizableui/CustomizeMode.jsm#1367

so I don't see why this would change based on which theme is selected... does the same thing happen in the add-ons manager?

Comment 2

[Itiel]

(In reply to :Gijs from comment #1)
> Is this a regression, or has it always been broken?
I know this has been there for a long time, though not sure if that's a regression or not. Investigating.

(In reply to :Gijs from comment #1)
> does the same thing happen in the add-ons manager?
Yes. The string(s) get non-localized when I change the theme to non-default, and after reverting back to Default and reloading the add-ons manager page, it gets back to my locale.

Comment 3

[Francesco Lodolo [:flod]]

I believe this is a dupe of bug 1402719, not sure if it's even older than that.

Comment 4

[:Gijs (he/him)]

(In reply to Francesco Lodolo [:flod] (workweek until Mar 30, slower than usual) from comment #3)
> I believe this is a dupe of bug 1402719, not sure if it's even older than
> that.

Yeah, there's a comment in there. Thanks!