Closed
Bug 1449357
Opened 6 years ago
Closed 6 years ago
Remove CheckForDoubleDefinition()
Categories
(Core :: Preferences: Backend, enhancement)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
Bug 1437168 introduced a check that would fail if you define a pref in StaticPrefsList.h and then override it in a prefs data file (such as all.js). This check is reasonable for Firefox, but not for Thunderbird, because Thunderbird relies on overriding prefs in exactly this way. (See bug So I will just disable the checking. I don't see how else to deal with this without causing huge problems for Thunderbird.
Assignee | ||
Comment 1•6 years ago
|
||
> (See bug ... bug 1449143
Comment 2•6 years ago
|
||
Well, no big damage done, it's about two preferences: pref("network.auth.subresource-img-cross-origin-http-auth-allow", true); pref("network.auth.non-web-content-triggered-resources-http-auth-allow", true); We've only introduced setting those quite recently to allow auth prompts when inserting images into a composition from a protected resource. We can live with not having them for a while. Would it be possible to maintain your checking, but provide a special override mechanism? Like override-pref("xxx", yyy); or pref("xxx", yyy, OVERRIDE); or !pref("xxx", yyy); or pref("xxx", yyy) !important; or anything else you deem fit.
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8962930 [details] Bug 1449357 - Let prefs in data files override prefs in StaticPrefsList.h. https://reviewboard.mozilla.org/r/231742/#review237356 How about adding a test (mochitest, probably) that checks there aren't overrides in the defaults we ship in Firefox?
Attachment #8962930 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #2) > Well, no big damage done, it's about two preferences: There will be more :) > Would it be possible to maintain your checking, but provide a special > override mechanism? Like > override-pref("xxx", yyy); Omitting the check is a lot simpler!
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/80f9b1f649db5f85bb42093725d4451786722444 Bug 1449357 - Let prefs in data files override prefs in StaticPrefsList.h. r=glandium
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/80f9b1f649db
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Assignee: nobody → n.nethercote
You need to log in
before you can comment on or make changes to this bug.
Description
•