1449357 - Remove CheckForDoubleDefinition()

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Nicholas Nethercote [inactive]]

Bug 1437168 introduced a check that would fail if you define a pref in StaticPrefsList.h and then override it in a prefs data file (such as all.js). This check is reasonable for Firefox, but not for Thunderbird, because Thunderbird relies on overriding prefs in exactly this way. (See bug 

So I will just disable the checking. I don't see how else to deal with this without causing huge problems for Thunderbird.

Comment 1

[Nicholas Nethercote [inactive]]

> (See bug 

... bug 1449143

Comment 2

[Jorg K (CEST = GMT+2)]

Well, no big damage done, it's about two preferences:
pref("network.auth.subresource-img-cross-origin-http-auth-allow", true);
pref("network.auth.non-web-content-triggered-resources-http-auth-allow", true);

We've only introduced setting those quite recently to allow auth prompts when inserting images into a composition from a protected resource. We can live with not having them for a while.

Would it be possible to maintain your checking, but provide a special override mechanism? Like
  override-pref("xxx", yyy);
or
  pref("xxx", yyy, OVERRIDE);
or
  !pref("xxx", yyy);
or
  pref("xxx", yyy) !important;
or anything else you deem fit.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1449357 - Let prefs in data files override prefs in StaticPrefsList.h.

This removes our ability to detect when an unnecessary override is occurring,
but it's necessary for Thunderbird to work.

Review commit: https://reviewboard.mozilla.org/r/231742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231742/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8962930 [details]
Bug 1449357 - Let prefs in data files override prefs in StaticPrefsList.h.

https://reviewboard.mozilla.org/r/231742/#review237356

How about adding a test (mochitest, probably) that checks there aren't overrides in the defaults we ship in Firefox?

Comment 5

[Nicholas Nethercote [inactive]]

(In reply to Jorg K (GMT+1) from comment #2)
> Well, no big damage done, it's about two preferences:

There will be more :)


> Would it be possible to maintain your checking, but provide a special
> override mechanism? Like
>   override-pref("xxx", yyy);

Omitting the check is a lot simpler!

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80f9b1f649db5f85bb42093725d4451786722444
Bug 1449357 - Let prefs in data files override prefs in StaticPrefsList.h. r=glandium

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/80f9b1f649db