1449513 - Intermittent Failures View doesn't allow to switch to other trees than autoland and trunk

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The comments as added by the Orange Factor robot in Bugzilla can not be analyzed in the Intermittent failures view because there is no way to switch to other trees than autoland and trunk. Take the following as example:

Comment as made yesterday: bug 1444831 comment 3

> 12 failures in 822 pushes (0.015 failures/push) were associated with this bug in the last 7 days.    
[..]
> Repository breakdown:
> * mozilla-beta: 11
> * mozilla-release: 1
[..]
For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1444831&startday=2018-03-20&endday=2018-03-26&tree=trunk

The failures view lists 0 failures, and the `Tree` dropdown at the top doesn't allow me to switch the tree. Instead I have to manually modify the URL:

https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2018-03-20&endday=2018-03-26&tree=mozilla-beta&bug=1444831

That interestingly gives me 10 failures but not the 11 as reported above.

Comment 1

[Geoff Brown [:gbrown]]

See also :philor's frustration in https://bugzilla.mozilla.org/show_bug.cgi?id=1452940#c4 and concerns about esr's.

Comment 2

[Sarah Clements [:sclements]]

Attachment: patch for Bug 1449513 & bug 1452940

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8972073 [details] [review]
patch for Bug 1449513 & bug 1452940

Sorry for the churn, but I think we should go with this, unless there are any objections?

(In reply to Phil Ringnalda (:philor) from comment #17)
> The lack of a mozilla-release on OF makes me suspect I'm not alone in not using individual
> trees, and we might well be able to cover every use with 'all', 'trunk',
> 'firefox-releases', 'firefox-esrs', 'comm-central', 'comm-releases'.

ie: add not just `all` as an alias, but also the names above and have `firefox-releases` map to `mozilla-{beta,release}`, `comm-releases` to `comm-{beta,release}`, etc

Comment 5

[Sarah Clements [:sclements]]

Attachment: patch

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8972073 [details] [review]
patch for Bug 1449513 & bug 1452940

Marking as obsolete, since there's a second attachment linking to the same PR.

(If asking for re-review, the original PR link attachment can be re-used, by going to "details" then selecting the reviewer again)

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8973359 [details] [review]
patch

Left a comment :-)

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8973359 [details] [review]
patch

Looks awesome - many thanks!

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/dd3c2d4f62d22e07932a572e131959af9a91bd36
Bug 1449513 and bug 1452940 - Add more repos to IFV (#3501)