1460731 - ESR branches shouldn't be combined into one "firefox-esrs" link

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

Looking at TH stage, I can see that the result of bug 1449513 was that all ESR branches are getting lumped into one group. ESR52 and ESR60 are wildly different branches, and combining their failures into one view will make it extremely difficult to get useful failure data. Can we please not lump them together?

Also, the esr45 branches are long-dead and don't need to be included anywhere, fwiw.

The same argument could also be made for beta & release, but that's probably not too bad in practice given the relative infrequency of pushes to m-r anyway.

Comment 1

[Phil Ringnalda (:philor)]

In retrospect, I agree: the single conceivable use-case for IFV on esr is "RyanVM looking at what tests are failing so frequently that he should disable them since nobody fixes failures on esr" for which we really only need the newest esr, but someone would complain if we removed the previous one when the new one started up rather than removing it after 12 weeks when it dies, so right now we should have an (unused) esr52 and an esr60 and a bug in August to remove esr52.

Pretty sure in practice beta+release sharing !NIGHTLY makes them more useful together than having separate lists to filter out things failing on release but fixed in beta's version, though.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Yeah, I don't feel nearly as strongly about firefox-releases. Probably not a big deal in practice. For ESR, we could probably get away with just showing the latest ESR release and calling it a day. By the time we're in that brief period of overlap supporting two releases, oranges on the older branch are highly unlikely to be something we care about much anyway as you noted.

Comment 3

[Sarah Clements [:sclements]]

To clarify, is there a need to have the esr's broken out (keeping only the most recent one or two) separately in the drop-down menu or is it fine as-is?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Let's just go with the latest esr and call it a day. By the time there's two releases overlapping, we're highly unlikely to care about oranges on the older one anymore anyway.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3575

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/946eb7a27ab3aadf76ec6115a6e311f6f6e0f504
Bug 1460731 - Update IFV repository aliases (#3575)

replace firefox-esrs and comm-esrs with lastest esr