1449572 - Write a raptor unit test for pageload timeouts

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P3)

Description

[Robert Wood [:rwood]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1449184#c3

Comment 1

[Alexandru Irimovici]

Attachment: Bug 1449571 - raptor unit test for pageload timeouts

Comment 2

[Robert Wood [:rwood]]

Hi Alexandru, thanks for the patch - please add a link to a try push (in ./mach try fuzzy --full you can type 'source-test-raptor` to find and select the Raptor unit test job) thanks!

Comment 3

[Robert Wood [:rwood]]

(In reply to Robert Wood [:rwood] from comment #2)

Hi Alexandru, thanks for the patch - please add a link to a try push (in ./mach try fuzzy --full you can type 'source-test-raptor` to find and select the Raptor unit test job) thanks!

Oh perhaps you don't have commit access yet to push to try, in which case please NI me back and I'll push your patch to try on your behalf, thanks!

Comment 4

[Ionuț Goldan [:igoldan]]

Here's the Try push for the latest changes.

Comment 5

[Alexandru Irimovici]

(In reply to Robert Wood [:rwood] from comment #2)

Hi Alexandru, thanks for the patch - please add a link to a try push (in ./mach try fuzzy --full you can type 'source-test-raptor` to find and select the Raptor unit test job) thanks!

Hi Robert, Ionut helped me with the pysh to try (https://treeherder.mozilla.org/#/jobs?repo=try&revision=37f7cfcd517a067a74c3ff23d190ebc3a0a716ae)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56befecef461
Bug 1449571 - raptor unit test for pageload timeouts r=perftest-reviewers,rwood

Comment 7

[Robert Wood [:rwood]]

Marking bug as 'leave-open' as the landed unit test is worthwhile (it tests the control server) but it doesn't test an actual page timeout itself. Let's see if we can add another test that will reproduce an actual page timeout in a Raptor pageload test.

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/56befecef461

Comment 9

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:airimovici, maybe it's time to close this bug?

Comment 10

[Alexandru Irimovici]

This will test code that is likely to be refactored. Can I unassign this or maybe wontfix it?

Comment 11

[Robert Wood [:rwood]]

(In reply to Alexandru Irimovici from comment #10)

This will test code that is likely to be refactored. Can I unassign this or maybe wontfix it?

Yes I agree, especially with the future switch to browsertime. Marking as FIXED because a patch did land already for this bug.