1449738 - Enable helper_hittest_backface_hidden.html for WR

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement)

Description

[Botond Ballo [:botond]]

In bug 1447131, I added an APZ mochitest to test hit-testing over a backface-visibility:hidden element.

The test is disabled for WR because that depends on a WR change [1]. This bug tracks enabling it.

We also discovered a bug in WR display list building that needs to be fixed for the test to pass.

[1] https://github.com/servo/webrender/pull/2585

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1449738 - Propagate backface-visibility information when building WebRender commands for CompositorHitTestInfo.

Review commit: https://reviewboard.mozilla.org/r/232260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232260/

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1449738 - Enable helper_hittest_backface_hidden.html for WebRender.

Review commit: https://reviewboard.mozilla.org/r/232262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232262/

Comment 3

[Botond Ballo [:botond]]

Posting the patches now, but they can't land until [1] is merged AND a WR update containing it lands.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8963352 [details]
Bug 1449738 - Propagate backface-visibility information when building WebRender commands for CompositorHitTestInfo.

https://reviewboard.mozilla.org/r/232260/#review237706

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8963353 [details]
Bug 1449738 - Enable helper_hittest_backface_hidden.html for WebRender.

https://reviewboard.mozilla.org/r/232262/#review237708

Comment 6

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #3)
> Posting the patches now, but they can't land until [1] is merged AND a WR
> update containing it lands.

(Actually, seeing as test_group_hittest is currently disabled for WR due to bug 1391318, it really doesn't matter, but it still feels more proper to wait for the fix to land before enabling the subtest.)

Comment 7

[Botond Ballo [:botond]]

Rebased on top of the WR update:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68ade20efe7501a00450d6d8ff69da3c3f6a5f59

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61cfa6a28bf9
Propagate backface-visibility information when building WebRender commands for CompositorHitTestInfo. r=kats
https://hg.mozilla.org/integration/autoland/rev/1a9acfb02c67
Enable helper_hittest_backface_hidden.html for WebRender. r=kats

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/61cfa6a28bf9
https://hg.mozilla.org/mozilla-central/rev/1a9acfb02c67