1449825 - Scrolling is all broke in prettyprinted file

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1) Enable the new debugger frontend.
2) Load https://www.bloomberg.com/news/articles/2018-02-06/stocks-in-asia-face-rally-as-u-s-equities-recover-markets-wrap
3) Find the bplayer.js file.
4) Prettyprint it, since it's otherwise all on 4 lines.
5) Search for this bit:

  {
    key: 'isInFullScreen',
    value: function () {
      if (u) {
        var e = a[s].status;
        return this._getDocumentProperty(e)
      }
    }
  },

around line 5470 of the prettyprinted stuff.

6) Set a breakpoint on line 5473 (the "if (u)") line.
7) Try to fullscreen the video.

EXPECTED RESULTS: Stop at the breakpoint, can examine u, a, etc, switch to console to evaluate expressions, switch back to step.

ACTUAL RESULTS: Pretty much everything is broken.  When stopped at the breakpoint, the view scrolls to some random line that is not the line the breakpoint is on.  When switching to console and back, the view scrolls to line 1 every time, so I have to find my place again.  Single-stepping scrolls to random other places in the file that are not where execution is, afaict...

Comment 1

[Jason Laster [:jlast]]

Thanks for reporting.

We are tracking the editor scrolling to line 1 here:
https://github.com/devtools-html/debugger.html/issues/5748

I will look into the pause scrolling soon

Comment 2

[Jason Laster [:jlast]]

Hmm, it looks like there is likely something fishy with the source map because the breakpoint is getting added to a surprising location in the minified code.

Comment 3

[:Harald Kirschner :digitarald]

Logan, with the recent fixes; is this expected to be fixed?

Comment 4

[Logan Smyth [:loganfsmyth]]

I'm not able to reproduce this now. Given the description, I'd say this is likely a case fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1503436.