1449992 - consider reusing the inner window for document.open()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently we create a new inner window when document.open() is called.  This follows the spec, but we are the only browser that implements this behavior.

In addition, we have at least one test that seems to expect DOM objects parented to the old inner window to continue functioning after document.open():

https://searchfox.org/mozilla-central/rev/7e663b9fa578d425684ce2560e5fa2464f504b34/dom/base/test/test_bug372964-2.html

In bug 1447871 I am re-binding DETH objects to the new inner window to keep this working.  It would be easier to explain, however, if the original inner window was simply reused.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This would need a clear description of what happens instead, then.

It would also need a definition of how this interacts with session history.

Comment 2

[Anne (:annevk)]

As far as I can tell it doesn't. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Document.cpp?q=Document.cpp&sq=package:chromium&dr&l=2902 ends up resetting a couple of things (selection, event listeners, children, parser) and that's pretty much it. I'm planning to write more tests for all this, but most of it looks pretty straightforward.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> As far as I can tell it doesn't

Right, that's the problem.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed by bug 1489308.