Closed Bug 1450321 Opened 6 years ago Closed 6 years ago

reflect/xptinfo code does not need to be threadsafe

Categories

(Core :: XPCOM, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1444745

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(3 files)

I believe that these classes are only used from XPConnect, which can only be used on the main thread, so they do not need to be threadsafe any more. (I think a lot of the locking was added in bug 614480.)

- XPTInterfaceInfoManager and xptiInterfaceInfo don't need to use threadsafe refcounting.
- XPTInterfaceInfoManager::mResolveLock can be removed
- xptiWorkingSet::mTableReentrantMonitor can be removed
- There are a bunch of methods with "lock" in the name that can be cleaned up.
- I think the unusual refcounting for xptiInterfaceInfo can be replaced with regular refcounting. The weak pointer for mEntry can be cleared in the dtor.
Blocks: 1444745
Blocks: 1450359
Priority: -- → P3
Depends on: 1450361
No longer blocks: 1444745
I'll wait and rebase this once Nika's XPT stuff lands.
Blocks: 1451425
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: