1450321 - reflect/xptinfo code does not need to be threadsafe

Status: RESOLVED DUPLICATE of bug 1444745

(Core :: XPCOM, defect, P3)

Description

[Andrew McCreight [:mccr8]]

I believe that these classes are only used from XPConnect, which can only be used on the main thread, so they do not need to be threadsafe any more. (I think a lot of the locking was added in bug 614480.)

- XPTInterfaceInfoManager and xptiInterfaceInfo don't need to use threadsafe refcounting.
- XPTInterfaceInfoManager::mResolveLock can be removed
- xptiWorkingSet::mTableReentrantMonitor can be removed
- There are a bunch of methods with "lock" in the name that can be cleaned up.
- I think the unusual refcounting for xptiInterfaceInfo can be replaced with regular refcounting. The weak pointer for mEntry can be cleared in the dtor.

Comment 1

[Andrew McCreight [:mccr8]]

I'll wait and rebase this once Nika's XPT stuff lands.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1450321, part 1 - Remove locks and threadsafe refcounting from reflect/xptinfo.

These classes can only be used from the main thread now that XPConnect
is single threaded.

Review commit: https://reviewboard.mozilla.org/r/233454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233454/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1450321, part 2 - Remove the Locked methods.

Now that there are no locks, there's no need for "Locked" methods.

Review commit: https://reviewboard.mozilla.org/r/233456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233456/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1450321, part 3 - Make xptiInterfaceInfo use normal refcounting.

This class can only be used on the main thread, so there's no need to
worry about an object going away from under us while we're in
Release(). The clearing of the weak pointer gets moved to the dtor.

Review commit: https://reviewboard.mozilla.org/r/233458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233458/