More cleanup after expression closure removal

RESOLVED FIXED in Firefox 61

Status

()

defect
P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Assignee

Description

a year ago
There are few more things that can be obviously removed. 

- ExpressionClosureHandling in the Parser
- Probably various other simplifications in the parser that aren't obvious to me
- DeprecatedLanguageExtension telemetry code that only handled expression closures

More .. ?
Assignee

Comment 1

a year ago
Actually ExpressionClosureHandling might still be needed for arrow function expression, I am not sure.
Assignee

Comment 2

a year ago
Assignee: nobody → evilpies
Attachment #8964876 - Flags: review?(jdemooij)
Assignee

Comment 3

a year ago
Attachment #8964876 - Attachment is obsolete: true
Attachment #8964876 - Flags: review?(jdemooij)
Attachment #8964878 - Flags: review?(jdemooij)
Comment on attachment 8964878 [details] [diff] [review]
Remove NoExpressionClosure FunctionSyntaxKind values

Review of attachment 8964878 [details] [diff] [review]:
-----------------------------------------------------------------

*steal*
Attachment #8964878 - Flags: review?(jdemooij) → review+
Priority: -- → P2
Assignee

Comment 5

a year ago
We should probably make FunctionSyntaxKind an enum class.
Attachment #8965027 - Flags: review?(jorendorff)

Comment 6

a year ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a136c8bccf1
Remove NoExpressionClosure FunctionSyntaxKind values. r=jorendorff
Assignee

Updated

a year ago
Keywords: leave-open
Comment on attachment 8965027 [details] [diff] [review]
Reove expressionClosureHandling

Review of attachment 8965027 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks.
Attachment #8965027 - Flags: review?(jorendorff) → review+

Comment 9

a year ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42b231ec2fbc
Remove expressionClosureHandling from Parser. r=jorendorff
Assignee

Comment 10

a year ago
Testing this on try before asking for review.
Assignee

Updated

a year ago
Attachment #8965512 - Flags: review?(jdemooij)
Comment on attachment 8965512 [details] [diff] [review]
Remove DeprecatedLanguageExtension telemetry code

Review of attachment 8965512 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent.
Attachment #8965512 - Flags: review?(jdemooij) → review+

Comment 13

a year ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/14f8ed32f8f0
Remove expressionClosureHandling from Parser: fix leftover merge conflict CLOSED TREE
Assignee

Updated

a year ago
Keywords: leave-open

Comment 14

a year ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84acd9df2fe4
Remove DeprecatedLanguageExtension telemetry code. r=jandem

Comment 15

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/14f8ed32f8f0
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee

Updated

a year ago
Blocks: 1453006
You need to log in before you can comment on or make changes to this bug.