1450574 - More cleanup after expression closure removal

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Tom S [:evilpie]]

There are few more things that can be obviously removed. 

- ExpressionClosureHandling in the Parser
- Probably various other simplifications in the parser that aren't obvious to me
- DeprecatedLanguageExtension telemetry code that only handled expression closures

More .. ?

Comment 1

[Tom S [:evilpie]]

Actually ExpressionClosureHandling might still be needed for arrow function expression, I am not sure.

Comment 2

[Tom S [:evilpie]]

Attachment: Remove NoExpressionClosure FunctionSyntaxKind values

Comment 3

[Tom S [:evilpie]]

Attachment: Remove NoExpressionClosure FunctionSyntaxKind values

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 8964878 [details] [diff] [review]
Remove NoExpressionClosure FunctionSyntaxKind values

Review of attachment 8964878 [details] [diff] [review]:
-----------------------------------------------------------------

*steal*

Comment 5

[Tom S [:evilpie]]

Attachment: Reove expressionClosureHandling

We should probably make FunctionSyntaxKind an enum class.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a136c8bccf1
Remove NoExpressionClosure FunctionSyntaxKind values. r=jorendorff

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0a136c8bccf1

Comment 8

[Jason Orendorff [:jorendorff]]

Comment on attachment 8965027 [details] [diff] [review]
Reove expressionClosureHandling

Review of attachment 8965027 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42b231ec2fbc
Remove expressionClosureHandling from Parser. r=jorendorff

Comment 10

[Tom S [:evilpie]]

Attachment: Remove DeprecatedLanguageExtension telemetry code

Testing this on try before asking for review.

Comment 11

[Jan de Mooij [:jandem]]

Comment on attachment 8965512 [details] [diff] [review]
Remove DeprecatedLanguageExtension telemetry code

Review of attachment 8965512 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent.

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/42b231ec2fbc

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14f8ed32f8f0
Remove expressionClosureHandling from Parser: fix leftover merge conflict CLOSED TREE

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84acd9df2fe4
Remove DeprecatedLanguageExtension telemetry code. r=jandem

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/14f8ed32f8f0

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/84acd9df2fe4