1453006 - Convert FunctionSyntaxKind to an enum class

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tom S. (please needinfo tschuster)]

Attachment: Convert FunctionSyntaxKind to an enum class

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 8966625 [details] [diff] [review]
Convert FunctionSyntaxKind to an enum class

Review of attachment 8966625 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: js/src/frontend/Parser.cpp
@@ +3000,5 @@
>          if (!tokenStream.getToken(&tt, firstTokenModifier))
>              return false;
>          if (tt != TokenKind::Lp) {
> +            error(kind == FunctionSyntaxKind::Arrow
> +                  ? JSMSG_BAD_ARROW_ARGS : JSMSG_PAREN_BEFORE_FORMAL);

Nit: \n before ":" ?

@@ +3730,5 @@
>      // function bodies are parsed with different yield/await settings.
>      {
> +        AwaitHandling awaitHandling =
> +            funbox->isAsync() || (kind == FunctionSyntaxKind::Arrow && awaitIsKeyword())
> +            ? AwaitIsKeyword : AwaitIsName;

Same here. Also maybe add parentheses around the condition while you're here - it's not obvious to me how `a || b ? x : y` is parsed.

Comment 2

[Jan de Mooij [:jandem]]

(Btw Splinter flags this as a "WINDOWS PATCH" but we can probably ignore that...)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3203bbe43b
Convert FunctionSyntaxKind to an enum class. r=jandem

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1b3203bbe43b