1450624 - Remove toolbox minimize feature

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Brian Birtles (:birtles)]

Bug 867838 introduced a toolbox minimize feature. Bug 1177463 disabled it 3 years ago pending UX discussion. That never happened and yet the code still (partially) exists.

As a newcomer to DevTools I'm finding this (unused) code confusing. I believe we should remove it. If we later decide we want this feature we should be able to cherry pick from the original patches to recreate it.

Patrick gave me the ok on slack to go ahead and remove this.

After doing this I suspect the following bugs should become invalid/wontfix:

* Bug 1173849 - If I drag the toolbox down to a minimum size, it should 'snap' to 'minimized'
* Bug 1178216 - Allow to minimize the toolbox even when it is in side docking mode
* Bug 1178213 - Toolbox toolbar should be displayed along the side in vertical dock mode

Comment 1

[Brian Birtles (:birtles)]

Attachment: Bug 1450624 - Remove toolbox minimize feature;

Review commit: https://reviewboard.mozilla.org/r/232982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232982/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8964238 [details]
Bug 1450624 - Remove toolbox minimize feature;

https://reviewboard.mozilla.org/r/232982/#review238720

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ac042ae5593
Remove toolbox minimize feature; r=pbro

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/8ac042ae5593