1450684 - [Windows] browser_style does not play well with themes

Status: RESOLVED WONTFIX

(WebExtensions :: General, defect, P3)

Description

[Emil Pasca [:emilpasca]]

**[Prerequisites]:**
- Have a Firefox profile with the latest "Firefox Notes" add-on version (3.1.0) installed (You can download it from here https://github.com/mozilla/notes/releases/tag/3.1.0 or https://testpilot.firefox.com/experiments/notes).
- Change the Windows theme option to "High Contrast # 1" or "High Contrast # 2".

**[Steps to reproduce]:**
1. Open the browser with the profile from prerequisites.
2. Observe the text in the "Notes" content area.
3. Click on the "Notes" sidebar switcher and observe the "Notes" text option and icon.

**[Expected result]:**
2. The text color in the "Notes" content area is white.
3. The "Notes" text option and icon color are green.

**[Actual result]:**
2. The text color in the "Notes" content area is dark grey(unreadable).
3. The "Notes" text option and icon color are white.

**[Additional Notes]:**
- Refs https://github.com/mozilla/notes/issues/417
- Attached a screen recording of the issue:
https://user-images.githubusercontent.com/20083658/33073434-9341166e-cecb-11e7-81a9-9ec28601a8a5.gif

Comment 1

[Vlad Filippov (:vladikoff)]

P.S. This is not a "Notes" only issue. Another addon you can try is https://addons.mozilla.org/en-US/firefox/addon/tab-center-redux/ to reproduce the contrast issues. I'm suspecting this is true for any "webby" content loaded into the sidebar

Comment 2

[:Gijs (he/him)]

This is caused by browser/components/extensions/extension.css setting the default background to transparent, and the default foreground colour to an opaque grey-ish colour. Because this is a browser stylesheet, it isn't subject to the high contrast restrictions and is applied, on top of the high contrast defaults, which means that the default background colour is black and the default foreground color is also black (ish). Add-on stylesheets themselves do get clobbered by HCM and so they can't fix this at all. The defaults need to be made high-contrast-friendly (probably best), or have high-contrast alternatives.

Shane, can you ensure this gets looked at and prioritized? Thanks!

Comment 3

[Shane Caraveo (:mixedpuppy)]

We triage bugs with no priority every Thursday.

I think we've a number of issues with browser_style that need to be addressed.

Comment 4

[Firefox Bug Husbandry Bot]

Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958

Comment 5

[Stefano]

Attachment: Wikipedia_Firefox_Gnome_Dark_Theme.png

I have running Gnome with dark theme. Firefox is using the system colors. On some webpages the contrast is very bad. See wikipedia example https://de.wikipedia.org/wiki/Normalverteilung

Comment 6

[Rob Wu [:robwu]]

Closing bug because support for browser_style feature is going to be removed (at least in MV3), see bug 1827910.