1450943 - Convert RootActor to protocol.js

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Description

[Yulia Startsev [:yulia]]

As part of migrating to protocol.js we need to update RootActor. However, RootActor instantiates a number of actors itself, that are not yet using Protocol.js and need to be updated as well.

The relationships are as follows (taken from ochameau's post in the parent bug)

* RootActor and the various TabActor sub classes it instantiates
  - RootActor
  - TabActor (never directly instanciated, only via sub-classes)
      ContentActor -> RootActor.getTab and RootActor.listTabs via BrowserTabActor.connect() and child.js
      ChromeActor -> RootActor.getProcess(0)
        WebExtensionChildActor -> (WebExtensionParentActor/webExtensionSpec).connect() via child.js
      WindowActor -> RootActor.getWindow()

  - BrowserAddonActor -> RootActor.listAddons
      AddonConsoleActor -> in BrowserAddonActor.form(), so during RootActor.listAddons
  - ChildProcessActor -> RootActor.getProcess via content-server.jsm

Comment 1

[Alexandre Poirot [:ochameau]]

Let's see if we can finaly do that.

And first, let's see what try says?
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79516800bdddfd4912bd96b6e85c8040e789a229

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1450943 - Convert RootActor to protocol.js.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1450943 - Remove unused helpers from devtools xpcshell tests.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:ochameau, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41873efa1c246e6e07a0ad5325f931939a42a0b1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ae1b9789e5d
Convert RootActor to protocol.js. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/9a78d85e2c71
Remove unused helpers from devtools xpcshell tests. r=jdescottes

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1ae1b9789e5d
https://hg.mozilla.org/mozilla-central/rev/9a78d85e2c71