Closed Bug 1450943 Opened 2 years ago Closed 1 month ago

Convert RootActor to protocol.js

Categories

(DevTools :: General, enhancement, P2)

enhancement

Tracking

(firefox74 fixed)

RESOLVED FIXED
Firefox 74
Tracking Status
firefox74 --- fixed

People

(Reporter: yulia, Assigned: ochameau)

References

(Blocks 3 open bugs)

Details

Attachments

(2 files)

As part of migrating to protocol.js we need to update RootActor. However, RootActor instantiates a number of actors itself, that are not yet using Protocol.js and need to be updated as well.

The relationships are as follows (taken from ochameau's post in the parent bug)

* RootActor and the various TabActor sub classes it instantiates
  - RootActor
  - TabActor (never directly instanciated, only via sub-classes)
      ContentActor -> RootActor.getTab and RootActor.listTabs via BrowserTabActor.connect() and child.js
      ChromeActor -> RootActor.getProcess(0)
        WebExtensionChildActor -> (WebExtensionParentActor/webExtensionSpec).connect() via child.js
      WindowActor -> RootActor.getWindow()

  - BrowserAddonActor -> RootActor.listAddons
      AddonConsoleActor -> in BrowserAddonActor.form(), so during RootActor.listAddons
  - ChildProcessActor -> RootActor.getProcess via content-server.jsm
Blocks: 1289193
Depends on: 1450946
Depends on: 1450948
Depends on: 1450950
Depends on: 1450953
Depends on: 1450956
No longer depends on: 1450946
No longer depends on: 1450948
No longer depends on: 1450950
No longer depends on: 1450953
Depends on: 1450958
Severity: normal → enhancement
Priority: -- → P2
Product: Firefox → DevTools
Depends on: 1472670
Depends on: 1473511
Depends on: 1473513

Let's see if we can finaly do that.

And first, let's see what try says?
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79516800bdddfd4912bd96b6e85c8040e789a229

Assignee: nobody → poirot.alex
Blocks: 1605384
Blocks: 1605390

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:ochameau, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(poirot.alex)
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ae1b9789e5d
Convert RootActor to protocol.js. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/9a78d85e2c71
Remove unused helpers from devtools xpcshell tests. r=jdescottes
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.