1451006 - FX_PREFERENCES_CATEGORY_OPENED_V2 Histogram Regression on 03-20-2018

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Seen here,
http://alerts.telemetry.mozilla.org/index.html#/detectors/1/metrics/2277/alerts/?from=2018-03-20&to=2018-03-20

The "unknown" category jumped from 0 to 0.46.

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c8dbb4ed05f38f40ef3607a6e36545bd95b8a287&tochange=025426a3e2e780d33bb666c78bfbaf22b3456c19

I believe that "home" is not being used as a category for this probe which is causing this spike.

Adding needinfo to k88hudson and mardak, as this is likely from either bug 1446053 or bug 1447153.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I don't really see how bug 1447153 could be involved - it's purely in the stylesheet for browser.xul, and doesn't impact how about:preferences is loaded at all... I'm going to tentatively unhook the bugs for now, unless you're seeing something I'm not.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Ah, that's because I had a typo in my bug numbers! :)

Comment 3

[Kate Hudson :k88hudson]

Yep, I'll take a look. Thanks!

Comment 4

[Kate Hudson :k88hudson]

Attachment: Bug 1451006 - Send correct category for about:preferences#home telemetry

Review commit: https://reviewboard.mozilla.org/r/233384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233384/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8964691 [details]
Bug 1451006 - Send correct category for about:preferences#home telemetry

https://reviewboard.mozilla.org/r/233384/#review239296

The "home" category isn't included in the list of labels at https://searchfox.org/mozilla-central/rev/a0665934fa05158a5a943d4c8b277465910c029c/toolkit/components/telemetry/Histograms.json#6405-6414

You'll need to add it to the list there. We should be fine with the current expiration of v66.

Comment 6

[Kate Hudson :k88hudson]

Comment on attachment 8964691 [details]
Bug 1451006 - Send correct category for about:preferences#home telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233384/diff/1-2/

Comment 7

[Kate Hudson :k88hudson]

Comment on attachment 8964691 [details]
Bug 1451006 - Send correct category for about:preferences#home telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233384/diff/2-3/

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8964691 [details]
Bug 1451006 - Send correct category for about:preferences#home telemetry

https://reviewboard.mozilla.org/r/233384/#review239482

Note that this will cause problems comparing data from before this lands to data after this lands. I don't think there is any way around it though.

Comment 9

[Kate Hudson :k88hudson]

That makes sense. Is there documentation or a chart somewhere I can leave a note/annotation if it would be helpful?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c12cad13a37
Send correct category for about:preferences#home telemetry r=jaws

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Kate Hudson :k88hudson from comment #9)
> That makes sense. Is there documentation or a chart somewhere I can leave a
> note/annotation if it would be helpful?

I don't think so but maybe Frank will know?

Comment 12

[Frank Bertsch [:frank]]

> That makes sense. Is there documentation or a chart somewhere I can leave a
> note/annotation if it would be helpful?

We only support adding a new category to the _END_ of the `"labels"` array.

You can document it by adding this bug to the `"bug_numbers"` array.

Comment 13

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 5c12cad13a37 (bug 1451006) on request of jaws

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5c12cad13a376db920516bacee86ec869883e524

Backout: https://hg.mozilla.org/integration/autoland/rev/5beb51ba1f10541c706e5246c890d2358496b13c

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07e5814d8e22
Send correct category for about:preferences#home telemetry r=jaws

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/07e5814d8e22

Comment 16

[Kate Hudson :k88hudson]

Thanks jaws!

Comment 17

[Chris H-C :chutten]

It worked! http://alerts.telemetry.mozilla.org/index.html#/detectors/1/metrics/2277/alerts/?from=2018-04-07&to=2018-04-07