Make viewing source work again in SeaMonkey after bug 1418403

NEW
Unassigned

Status

P3
major
8 months ago
5 months ago

People

(Reporter: frg, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.57esr affected, seamonkey2.58 affected)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

8 months ago
Bug 1418403 broke viewing source code in SeaMonkey and TB. TB restored some functionality in bug 1439021 but we need to further adapt this.

+++ This bug was initially created as a clone of Bug #1418403 +++

This was mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1416372#c3, so spinning it off into a new bug.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1416372#c2:

When we collected data on the different modes 2 years ago (bug 1203624 comment 11), we saw:

View Source in Browser:         56,700 uses (99.30%)
View Source in Window:             357 uses ( 0.62%)
View Source External (Success):     44 uses ( 0.08%)
View Source External (Failed):      48 uses (re-counted as browser / window above)

Maybe these numbers are low enough that we should remove the pref and the additional code to support both modes.
(Reporter)

Comment 1

8 months ago
Created attachment 8964651 [details] [diff] [review]
1451081-viewSource-wip.diff

WIP patch from stefanh with a quick copy/paste from me (browser.js to navigator.js). We think we should keep the e10s parts to ease later porting.

We would prefer to open a new browser window insetad of a tab but this might not be so easy as I thought.

Stefan do you want to take the bug?
Flags: needinfo?(stefanh)
(Reporter)

Updated

8 months ago
Summary: Remove view_source.tab pref → Make viewing source work again in SeaMonkey after bug 1418403
(Reporter)

Updated

8 months ago
Blocks: 1433370

Comment 2

7 months ago
frg, the patch you provided is on top of a bunch of other patches. Hmm, skip the overlay now when it doesn't open in a new window?
Flags: needinfo?(stefanh) → needinfo?(frgrahl)
(Reporter)

Comment 3

7 months ago
> frg, the patch you provided is on top of a bunch of other patches.

Sent you my patch queue. SeaMoneky dumps without it.

> Hmm, skip the overlay now when it doesn't open in a new window?

The overlay probably needs to be removed. Doesn't make sense any longer with opening the source directly in the browser and they need to go anyway. But hard to test with mail broken. For opening the source in a Window we would need to create a new browser and then get the tab. handURIToExistingBrowser or another function can probably not be used because we need the tab value. So also not sure if it is worth it to figure it out. Maybe in a followup bug.
Flags: needinfo?(frgrahl)
(Reporter)

Comment 4

5 months ago
Created attachment 8985855 [details] [diff] [review]
1451081-WIP-viewSource-257.patch

Rebased 2.57 wip patch
Attachment #8964651 - Attachment is obsolete: true
(Reporter)

Comment 5

5 months ago
Created attachment 8985856 [details] [diff] [review]
1451081-WIP-viewSource.patch

Rebased c-c wip patch
You need to log in before you can comment on or make changes to this bug.