1451212 - Remove EventManager compatibility hack

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Andrew Swan [:aswan]]

In bug 1450388, the signature for creating a WebExtension EventManager will be changing (this is a class used in the implementation of extension apis, not something directly visible to extensions).  All in-tree uses will be converted, but a shim will be added to avoid immediately breaking any WebExtension experiments.

This bug is to follow up by announcing the change to give experiment implementers time to update, and then remove the shim.

Comment 1

[Andrew Swan [:aswan]]

I announced this here:
https://mail.mozilla.org/pipermail/firefox-dev/2018-April/006334.html

Mike, should this be announced anywhere else?  In any case, I propose we remove it in 63 (that way anybody writing an experiment that targets 60 can keep the old style and have it work on all channels until 61 goes to release)

Comment 2

[Mike Conca [:mconca]]

(In reply to Andrew Swan [:aswan] from comment #1)
> I announced this here:
> https://mail.mozilla.org/pipermail/firefox-dev/2018-April/006334.html
> 
> Mike, should this be announced anywhere else?  In any case, I propose we
> remove it in 63 (that way anybody writing an experiment that targets 60 can
> keep the old style and have it work on all channels until 61 goes to release)

I don't think this needs to be announced anywhere else. The blogs, add-ons and hacks, target extension and web developers respectively. From what I can tell, we've never discussed experiments in either blog. Emailing to dev-addons might create more confusion than clarity, since (I suspect) most extension devs aren't aware of experiments and will assume the announcement refers to the WebExtension API. I also don't see any documentation on MDN that needs to be updated.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1451212 remove backward compat code in EventManager class

Comment 4

[Shane Caraveo (:mixedpuppy)]

Blocked by https://github.com/mozilla/price-tracker/issues/318

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/180c44b95a66
remove backward compat code in EventManager class r=robwu

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/180c44b95a66

Comment 7

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!