Closed Bug 1575537 Opened 6 years ago Closed 6 years ago

Experiment APIs breaking at activityLog call, with "this.context is undefined"

Categories

(WebExtensions :: Experiments, defect)

Product:
WebExtensions
Component:
Experiments
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: zombie, Unassigned)

References

Details

https://github.com/mikeconley/ohnoreflow/

When loading Mike's Oh no! Reflow! (either temporarily or by disabling signatures), which includes an experiment API, the following error is thrown in the browser console:

TypeError: this.context is undefined ExtensionCommon.jsm:2364:5

which points at:

​https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionCommon.jsm#2364

Not sure if the problem is inside the experiment API or the newly added activity logging.

From a quick look to the oh-no-reflow sources (in particular where EventManager is being used) I think that the regression is actually being introduced by Bug 1451212 (Remove EventManager compatibility hack).

Blocks: 1451212
Regressed by: 1451212

I've updated OhNoReflow and SpinDoctor (my two add-ons that use the WebExtension experiments API) to use the more modern form of arguments for EventManager, and that seems to have fixed things. I'm all good here now - thank you!

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
No longer blocks: WE-activityLog
Keywords: regression
No longer regressed by: 1451212
You need to log in before you can comment on or make changes to this bug.