1451283 - Collapsible groupboxes and the "collapsable" class will be removed from mozilla-central

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[:Paolo Amadini]

Collapsible groupboxes and the "collapsable" class will be removed from mozilla-central along with the last use of them. The associated logic and styling can be moved to comm-central.

Comment 1

[Richard Marti (:Paenglab)]

Thank you, Paolo. I'm following bug 1451282 and can then hopefully port your changes.

Comment 2

[:Paolo Amadini]

I didn't notice in the comm-central search that the "collapsable" class is already defined locally in the individual windows that use the feature, so there is probably nothing to do here. Sorry for the noise!

We may remove groupboxes at some point, but they might be kept as Custom Elements.

Comment 3

[:Paolo Amadini]

I ended up removing "arrow-rit.gif" from the OS X theme since it's now unused, it may be something you need to track.

Comment 4

[Richard Marti (:Paenglab)]

Thanks, will do.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: No-arrow-rit.gif.patch

I decided to completely switch to our icons for editor and, on Mac the datetimepicker. Linux and Windows use already our icons for the datetimepicker.

I had to fix also an issue in EdTableProps.xul to make the arrows showing correct and not stretched in the buttons. To test the buttons, create a table and then with the selected table choose Format > Table Cell Properties...

I couldn't check #MoreFewerButton because it seems TB doesn't use this dialogs. Maybe we should check which dialogs we use and only package them.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8965935 [details] [diff] [review]
No-arrow-rit.gif.patch

Review of attachment 8965935 [details] [diff] [review]:
-----------------------------------------------------------------

Looks very nice now.

::: mail/themes/osx/mail/datetimepicker.css
@@ +90,5 @@
>    padding: 0;
>  }
>  
> +.datepicker-previous,
> +.datepicker-next:-moz-locale-dir(rtl) {

Why this change?

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+1) from comment #6)
> Comment on attachment 8965935 [details] [diff] [review]
> No-arrow-rit.gif.patch
> > +.datepicker-previous,
> > +.datepicker-next:-moz-locale-dir(rtl) {
> 
> Why this change?

To be in sync with Linux and Windows and to be RTL safe.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bd38f0c95c82
Fix some Editor dialog buttons after the removal of the OS X arrow-rit.gif in M-C in bug 1451282. r=jorgk