Closed
Bug 1451314
Opened 6 years ago
Closed 6 years ago
Update Debugger Frontend v32
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 1 obsolete file)
52.66 KB,
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=609a468b1ebcd08c466f81baa99ec90ff2eb0505
Assignee | ||
Comment 2•6 years ago
|
||
first try was green https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8adf3a364c89bbc7499c937e73907ccf815ae75
Assignee | ||
Comment 3•6 years ago
|
||
second try green is green!
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8965684 -
Flags: review?(jdescottes)
Comment 5•6 years ago
|
||
Comment on attachment 8965684 [details] [diff] [review] rel-32.patch Review of attachment 8965684 [details] [diff] [review]: ----------------------------------------------------------------- R+ with: - rebased patch - fixed readme Had a comment about the new file, but I guess we don't have anything to exclude files? Maybe it would have been best to leave it in a non synchronized folder in the debugger repo. ::: devtools/client/debugger/new/README.mozilla @@ +1,4 @@ > This is the debugger.html project output. > See https://github.com/devtools-html/debugger.html > > +Version 17.0 Wrong versions ::: devtools/client/debugger/new/debugger.css @@ -2845,5 @@ > flex: 0 1 content; > order: 3; > } > > -:root.theme-light .breakpoint-snippet, As discussed, needs rebase because of https://bugzilla.mozilla.org/show_bug.cgi?id=1378108 ::: devtools/client/debugger/new/test/mochitest/examples/babel/source-maps-semantics.md @@ +1,1 @@ > +# Source Map Semantics Is this file really supposed to be synchronized or is it just because we blindly copy the whole test folder?
Attachment #8965684 -
Flags: review?(jdescottes) → review+
Assignee | ||
Comment 6•6 years ago
|
||
blind copy, i'll leave it out
Assignee | ||
Comment 7•6 years ago
|
||
Attachment #8965684 -
Attachment is obsolete: true
Attachment #8965840 -
Flags: review+
Assignee | ||
Comment 8•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=191bd1ab92d7be0627d4eb5833b9eba8bdc68eed
Assignee | ||
Comment 9•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cecd1e812f3491f68c6f14257f728c092acdfb6
Comment 10•6 years ago
|
||
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1a7f56d4af25 Update Debugger Frontend v32. r=jdescottes
Assignee | ||
Comment 11•6 years ago
|
||
Looks like v32 some how broke the custom debugger talos test :/ https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1a7f56d4af25927c756f94f333068ba5499b2895&selectedJob=172407439
Comment 12•6 years ago
|
||
Backed out changeset 1a7f56d4af25 (bug 1451314) for g2 failures in debugger/custom.js: Test timed out on a CLOSED TREE Problematic push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1a7f56d4af25927c756f94f333068ba5499b2895&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=172405094 Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c4b19afa06ea11c16ff3983a69e6c3aa1fdad8de&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Log: https://treeherder.mozilla.org/logviewer.html#?job_id=172405094&repo=mozilla-inbound&lineNumber=1315 16:29:01 INFO - PID 31046 | Run function in content process: window.hitBreakpoint() 16:33:57 INFO - PID 31046 | TEST-UNEXPECTED-FAIL | damp | debugger/custom.js: Test timed out 16:33:57 INFO - Terminating psutil.Process(pid=31046, name='firefox', started='16:27:55') 16:33:57 INFO - TEST-UNEXPECTED-ERROR | damp | unexpected error 16:33:57 ERROR - Traceback (most recent call last): 16:33:57 INFO - File "/home/cltbld/workspace/build/tests/talos/talos/run_tests.py", line 296, in run_tests 16:33:57 INFO - talos_results.add(mytest.runTest(browser_config, test)) 16:33:57 INFO - File "/home/cltbld/workspace/build/tests/talos/talos/ttest.py", line 63, in runTest 16:33:57 INFO - return self._runTest(browser_config, test_config, setup) 16:33:57 INFO - File "/home/cltbld/workspace/build/tests/talos/talos/ttest.py", line 207, in _runTest 16:33:57 INFO - debugger_args=browser_config['debugger_args'] 16:33:57 INFO - File "/home/cltbld/workspace/build/tests/talos/talos/talos_process.py", line 156, in run_browser 16:33:57 INFO - raise TalosError("unexpected error") 16:33:57 INFO - TalosError: unexpected error 16:33:57 INFO - TEST-INFO took 361711ms 16:33:57 INFO - SUITE-END | took 361s 16:33:58 ERROR - Return code: 2 16:33:58 WARNING - setting return code to 2 16:33:58 ERROR - # TBPL FAILURE #
Flags: needinfo?(jlaster)
Assignee | ||
Comment 13•6 years ago
|
||
Thanks stefan. https://treeherder.mozilla.org/#/jobs?repo=try&revision=f81a24bfc356715d62940f4aec901cc16192ef08 kicking off a new try run for just talos T-e10s to see if it passes without map-scopes. If it does, we can re-land 32 w/o map-scopes and try to isolate the issue.
Flags: needinfo?(jlaster)
Comment 14•6 years ago
|
||
For the record, you can run DAMP tests locally. This one-liner will run the custom debugger test. ./mach talos-test --activeTests damp --subtest custom.debugger --cycles 1 --tppagecycles 1 And it does pass when flipping devtools.debugger.features.map-scopes to false.
Comment 15•6 years ago
|
||
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4e39c75b7189 Update Debugger Frontend v32. r=jdescottes
Assignee | ||
Comment 16•6 years ago
|
||
try 2 sans map-scopes
Comment 17•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4e39c75b7189
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment 18•6 years ago
|
||
talos compare: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=332066907598e957afb1b4d6868d92cbd6d7a8a3&newProject=try&newRevision=4bfc30354c164eec74dd76f4ca1c4edb8907cfc2&framework=1
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•