1451378 - Enable ESLint rule no-undef for more test files in devtools

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Mark Banner (:standard8)]

The patch I'm attaching fixes no-undef for the majority of the remaining devtools folders, there's still a couple left, which I'll handle in a later bug.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1451378 - Enable ESLint rule no-undef for more test files in devtools.

Review commit: https://reviewboard.mozilla.org/r/233706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233706/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8964972 [details]
Bug 1451378 - Enable ESLint rule no-undef for more test files in devtools.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233706/diff/1-2/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8964972 [details]
Bug 1451378 - Enable ESLint rule no-undef for more test files in devtools.

https://reviewboard.mozilla.org/r/233706/#review239396

Thanks again! Works for me if try is green.

::: devtools/server/tests/browser/browser_actor_error.js:29
(Diff revision 2)
>    await gClient.connect();
>  
>    let { errorActor } = await gClient.listTabs();
>    ok(errorActor, "Found the error actor.");
>  
> -  try {
> +  Assert.rejects(gClient.request({ to: errorActor, type: "error" }),

Thanks for fixing that! I should have use Assert.rejects from the beginning here. The actual error we should check here is async:

  await Assert.rejects(gClient.request({ to: errorActor, type: "error" }),
    err => err.error == "unknownError" &&
           /error occurred while processing 'error/.test(err.message),
    "The request should be rejected");
    
I can handle it in a follow up, given it's already not testing anything relevant right now.

::: devtools/shared/heapsnapshot/tests/unit/head_heapsnapshot.js:114
(Diff revision 2)
>      filePrePath += "/";
>    }
>  
>    path = path.slice(filePrePath.length);
>  
> -  if (sePlatformPathSeparator && path.match(/^\w:/)) {
> +  if (usePlatformPathSeparator && path.match(/^\w:/)) {

logically, this argument was never used.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8964972 [details]
Bug 1451378 - Enable ESLint rule no-undef for more test files in devtools.

https://reviewboard.mozilla.org/r/233706/#review239396

> Thanks for fixing that! I should have use Assert.rejects from the beginning here. The actual error we should check here is async:
> 
>   await Assert.rejects(gClient.request({ to: errorActor, type: "error" }),
>     err => err.error == "unknownError" &&
>            /error occurred while processing 'error/.test(err.message),
>     "The request should be rejected");
>     
> I can handle it in a follow up, given it's already not testing anything relevant right now.

I'll fix it here, since I should have included the await - which also has helped me spot there's more awaits missing in the tree for Assert.rejects (!).

> logically, this argument was never used.

Yeah, since this was also in devtools/server/tests/unit/head_dbg.js, I think I decided to keep this the same.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8964972 [details]
Bug 1451378 - Enable ESLint rule no-undef for more test files in devtools.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233706/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b603bf3ea53
Enable ESLint rule no-undef for more test files in devtools. r=jdescottes

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8b603bf3ea53