Closed Bug 1230193 Opened 5 years ago Closed 2 years ago
remove no-undef from .eslintrc
59 bytes, text/x-review-board-request
Now that the head.js importer has landed, it seems like it should be possible to remove the "no-undef" rule from devtools/.eslintrc.xpcshell
Note that the head.js global importer is broken for some versions of eslint. I'm fixing it here: bug 1230093. I agree that we need to remove the no-undef: 0 from this config file.
After bug 1451378, there's just two more test directories to do. I'm hoping to take them on soon.
Assignee: nobody → standard8
The final part of this depends on bug 1456762, for which I've got a patch in the review queue.
Depends on: 1456762
Comment on attachment 8985909 [details] Bug 1230193 - Finish enabling ESLint rule no-undef for devtools/. https://reviewboard.mozilla.org/r/251398/#review257860 Looks good, thanks! For info, I logged a few devtools/eslint bugs to remove the remaining overrides: https://bugzilla.mozilla.org/show_bug.cgi?id=1467767 If there are other existing bugs that might be duplicates of those, could you point me to them?
Attachment #8985909 - Flags: review?(jdescottes) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4ef2cc1caddb Finish enabling ESLint rule no-undef for devtools/. r=jdescottes
You need to log in before you can comment on or make changes to this bug.