Closed Bug 1230193 Opened 8 years ago Closed 5 years ago

remove no-undef from .eslintrc.xpcshell

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: tromey, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1230193 - Finish enabling ESLint rule no-undef for devtools/.
59 bytes, text/x-review-board-request
jdescottes
: review+
Details 
Now that the head.js importer has landed, it seems like it should
be possible to remove the "no-undef" rule from devtools/.eslintrc.xpcshell
Note that the head.js global importer is broken for some versions of eslint. I'm fixing it here: bug 1230093.
I agree that we need to remove the no-undef: 0 from this config file.
Depends on: 1240163
Priority: -- → P3
Depends on: 1443661
Depends on: 1447944
Depends on: 1451378
After bug 1451378, there's just two more test directories to do. I'm hoping to take them on soon.
Assignee: nobody → standard8
Depends on: 1455581
Blocks: 1456634
Depends on: 1456755
Product: Firefox → DevTools
The final part of this depends on bug 1456762, for which I've got a patch in the review queue.
Depends on: 1456762
Comment on attachment 8985909 [details]
Bug 1230193 - Finish enabling ESLint rule no-undef for devtools/.

https://reviewboard.mozilla.org/r/251398/#review257860

Looks good, thanks! 

For info, I logged a few devtools/eslint bugs to remove the remaining overrides: https://bugzilla.mozilla.org/show_bug.cgi?id=1467767 
If there are other existing bugs that might be duplicates of those, could you point me to them?
Attachment #8985909 - Flags: review?(jdescottes) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ef2cc1caddb
Finish enabling ESLint rule no-undef for devtools/. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/4ef2cc1caddb
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.