Open Bug 1451808 Opened 2 years ago Updated 2 years ago

Intermittent border-radius/intersecting-clipping-1-refc.html == border-radius/intersecting-clipping-1-ref.html | image comparison, max difference: 81, number of differing pixels: 323

Categories

(Core :: Layout, defect, P5)

defect

Tracking

()

Tracking Status
firefox62 --- disabled
firefox63 --- disabled

People

(Reporter: intermittent-bug-filer, Assigned: jwatt, NeedInfo)

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])

Attachments

(1 file)

There are 30 failures for the past week, they occur on windows10-64 debug.

Recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=178626882&lineNumber=5085

Log snippet:

21:49:19     INFO -  REFTEST TEST-START | file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/intersecting-clipping-1-refc.html == file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/intersecting-clipping-1-ref.html
21:49:19     INFO -  REFTEST INFO | REFTEST fuzzy test (0, 0) <= (81, 323) <= (59, 350)
21:49:19     INFO -  --DOMWINDOW == 74 (000001C75D468C00) [pid = 496] [serial = 38] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/percent-3-ref.html]
21:49:19     INFO -  --DOMWINDOW == 73 (000001C75D469000) [pid = 496] [serial = 37] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/percent-3.html]
21:49:19     INFO -  --DOMWINDOW == 72 (000001C75D463C00) [pid = 496] [serial = 36] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 71 (000001C75E756800) [pid = 496] [serial = 60] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 70 (000001C75D46B000) [pid = 496] [serial = 35] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/percent-2-ref.html]
21:49:19     INFO -  --DOMWINDOW == 69 (000001C75D461400) [pid = 496] [serial = 72] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/clipping-4-canvas.html]
21:49:19     INFO -  --DOMWINDOW == 68 (000001C75C0ED000) [pid = 496] [serial = 70] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/clipping-4-notref.html]
21:49:19     INFO -  --DOMWINDOW == 67 (000001C75C0E9000) [pid = 496] [serial = 69] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/clipping-4-ref.html]
21:49:19     INFO -  --DOMWINDOW == 66 (000001C75C0E7000) [pid = 496] [serial = 61] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/clipping-1.html]
21:49:19     INFO -  --DOMWINDOW == 65 (000001C75E758400) [pid = 496] [serial = 62] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/clipping-1-ref.html]
21:49:19     INFO -  --DOMWINDOW == 64 (000001C75E60C800) [pid = 496] [serial = 63] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 63 (000001C75E755000) [pid = 496] [serial = 64] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/clipping-2.html]
21:49:19     INFO -  --DOMWINDOW == 62 (000001C75E617400) [pid = 496] [serial = 65] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 61 (000001C75C0EF400) [pid = 496] [serial = 73] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 60 (000001C75C0EB800) [pid = 496] [serial = 68] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 59 (000001C75BFC6000) [pid = 496] [serial = 67] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/clipping-3-ref.xhtml]
21:49:19     INFO -  --DOMWINDOW == 58 (000001C75C0F0C00) [pid = 496] [serial = 71] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 57 (000001C75E61AC00) [pid = 496] [serial = 66] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/clipping-3.html]
21:49:19     INFO -  --DOMWINDOW == 56 (000001C75E612C00) [pid = 496] [serial = 52] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/corner-3.html]
21:49:19     INFO -  --DOMWINDOW == 55 (000001C75D46B400) [pid = 496] [serial = 39] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 54 (000001C75E60DC00) [pid = 496] [serial = 53] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/corner-3-ref.svg]
21:49:19     INFO -  --DOMWINDOW == 53 (000001C75E613C00) [pid = 496] [serial = 54] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 52 (000001C75BFC5400) [pid = 496] [serial = 75] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 51 (000001C75E60F800) [pid = 496] [serial = 51] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 50 (000001C75D46D000) [pid = 496] [serial = 40] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/border-circle-2.html]
21:49:19     INFO -  --DOMWINDOW == 49 (000001C75E615C00) [pid = 496] [serial = 55] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/corner-4.html]
21:49:19     INFO -  --DOMWINDOW == 48 (000001C75E610C00) [pid = 496] [serial = 50] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/corner-2-ref.svg]
21:49:19     INFO -  --DOMWINDOW == 47 (000001C75E612800) [pid = 496] [serial = 56] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/corner-4-ref.svg]
21:49:19     INFO -  --DOMWINDOW == 46 (000001C75E60EC00) [pid = 496] [serial = 49] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/corner-2.html]
21:49:19     INFO -  --DOMWINDOW == 45 (000001C75D46B800) [pid = 496] [serial = 41] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/border-circle-2-ref.xhtml]
21:49:19     INFO -  --DOMWINDOW == 44 (000001C75E618000) [pid = 496] [serial = 57] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 43 (000001C75E60C000) [pid = 496] [serial = 48] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 42 (000001C75D464400) [pid = 496] [serial = 34] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/percent-2.html]
21:49:19     INFO -  --DOMWINDOW == 41 (000001C75D46F400) [pid = 496] [serial = 47] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/corner-1-ref.svg]
21:49:19     INFO -  --DOMWINDOW == 40 (000001C75E60FC00) [pid = 496] [serial = 46] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/corner-1.html]
21:49:19     INFO -  --DOMWINDOW == 39 (000001C75E614800) [pid = 496] [serial = 58] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/border-reduce-height.html]
21:49:19     INFO -  --DOMWINDOW == 38 (000001C75E60E800) [pid = 496] [serial = 45] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 37 (000001C75D470400) [pid = 496] [serial = 42] [outer = 0000000000000000] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
21:49:19     INFO -  --DOMWINDOW == 36 (000001C75E615800) [pid = 496] [serial = 59] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/border-reduce-height-ref.html]
21:49:19     INFO -  --DOMWINDOW == 35 (000001C75D46A800) [pid = 496] [serial = 44] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/curved-stripe-border-ref.svg]
21:49:19     INFO -  --DOMWINDOW == 34 (000001C75D470800) [pid = 496] [serial = 43] [outer = 0000000000000000] [url = file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/curved-stripe-border.html]
21:49:19    ERROR -  REFTEST TEST-UNEXPECTED-FAIL | file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/intersecting-clipping-1-refc.html == file:///C:/Users/task_1526420479/build/tests/reftest/tests/layout/reftests/border-radius/intersecting-clipping-1-ref.html | image comparison, max difference: 81, number of differing pixels: 323
Flags: needinfo?(mreavy)
Whiteboard: [stockwell needswork]
Hi Jonathan -- Any idea what may have changed here to bump the frequency of this intermittent?  (Perhaps a change in the tests?)
Flags: needinfo?(mreavy) → needinfo?(jwatt)
Update:
  There have been 32 failures in the last week, all of them on Windows 10x64, mostly on debug - 27 failures, and 5 failures on opt+pgo.
Over the last 7 days there are 30 failures present on this bug. These happen only on windows10-64.
Here isthe most recent log example: https://treeherder.mozilla.org/logviewer.html#?job_id=181605797&repo=mozilla-inbound&lineNumber=39042

12:08:23    ERROR -  REFTEST TEST-UNEXPECTED-FAIL | file:///C:/Users/task_1528025442/build/tests/reftest/tests/layout/reftests/border-radius/intersecting-clipping-1-refc.html == file:///C:/Users/task_1528025442/build/tests/reftest/tests/layout/reftests/border-radius/intersecting-clipping-1-ref.html | image comparison, max difference: 81, number of differing pixels: 323
Flags: needinfo?(mreavy)
Flags: needinfo?(mreavy)
Flags: needinfo?(jwatt)
Hi Jonathan -- Any idea what may have changed here to bump the frequency of this intermittent?  (Perhaps a change in the tests?)
I know we're at all-hands, but can you look anyways?  Thanks
Flags: needinfo?(jwatt)
The test and reference haven't changed since 2012, so this wasn't caused by a test change.

Looking at the graph of "Orange Count per Push" this first occurred on 4th April on a Try push that included the patch for bug 1448544 to remove AutoVsyncTelemetry. It occurred again three days later on the 7th (this time on autoland) which is the day that the patch for bug 1448544 landed.

The test is failing due to slight (invisible to the naked eye) aliasing issues around the edge of the clipping radii. I imagine what's happening here is that this is just another case of a race condition where the reftest harness doesn't wait for layers to flatten before taking its snapshot. Probably the removal of the AutoVsyncTelemetry code in bug 1448544 has sped up painting slightly, and that timing change means that we're now more likely to snapshot while the clipping layer is active.

At any rate, the rendering issues here are not a big issue. We have tons of reftests that we fuzz for slight differences in aliasing around the edges of shapes due to the flattening race, and due to expected differences in rendering paths. We should just add some fuzz to the manifest for this test.
Flags: needinfo?(jwatt)
Assignee: nobody → jwatt
Flags: needinfo?(jwatt)
In the last 7 days, there have been 57 failures.

For the failure pattern see Comment 8

An example of a recent log file: https://treeherder.mozilla.org/logviewer.html#?job_id=184619519&repo=autoland&lineNumber=61003

:jwatt, are there any updates here? 
Thank you!
Created this patch to disable this test on Windows to be available to find it necessary.
@Joel, if this is ok, should we go ahead and land this patch?
Flags: needinfo?(jmaher)
Attachment #8988470 - Flags: review?(jmaher)
Comment on attachment 8988470 [details] [diff] [review]
Disabled on Windows for requent failures

Review of attachment 8988470 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8988470 - Flags: review?(jmaher) → review+
Flags: needinfo?(jmaher)
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b0f73ff4482
Disable border-radius/intersecting-clipping-1-refc.html on Windows for frequent failures. r=jmaher
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.