Closed Bug 1451968 Opened 5 years ago Closed 5 years ago

Add comm-central branches to taskgraph project aliases.

Categories

(Thunderbird :: Build Config, enhancement)

Product:
Thunderbird
Component:
Build Config
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 61.0

People

(Reporter: tomprince, Assigned: tomprince)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 1451968: Add comm-central bracnhes to taskgraph project aliases; r?dustin
45 bytes, text/x-phabricator-request
dustin
: review+
Details | Review
comm-trunk.patch
1.22 KB, patch
dustin
: review+
Details | Diff | Splinter Review 
There are several project aliases for taskgraph's `run_on_projects`. Add the appropriate comm-* branches to those aliases.
There are several project aliases for taskgraph's `run_on_projects`. Add the
appropriate `comm-*` branches to those aliases.
Attachment #8965735 - Flags: review?(dustin)
Comment on attachment 8965735 [details]
Bug 1451968: Add comm-central bracnhes to taskgraph project aliases; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D863
Attachment #8965735 - Flags: review+
Attachment #8965735 - Flags: review?(dustin)
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/918004b0cc5d
Add comm-central bracnhes to taskgraph project aliases; r=dustin
https://hg.mozilla.org/mozilla-central/rev/918004b0cc5d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
Backout by philringnalda@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/cb2bb4a7c1c3
Backed out changeset 918004b0cc5d for breaking comm-central builds, a=shame
https://hg.mozilla.org/mozilla-central/rev/cb2bb4a7c1c3
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch comm-trunk.patch (obsolete) — — Splinter Review 

        Attachment #8966259 -
        Flags: review?(dustin)

    
    

    
  
Comment on attachment 8966259 [details] [diff] [review]
comm-trunk.patch

Review of attachment 8966259 [details] [diff] [review]:
-----------------------------------------------------------------

::: projects.yml
@@ +21,4 @@
>  # - `features` -- features that should be enabled for this project, as an object with boolean
>  #                 values, defaulting to false
>  #   - `buildbot` -- Buildbot builders configured for the branch
> +#   - 'is-trunk' -- index namespaces of the form `index.<trust-domain>.v2.trunk.revision.*

Rather than describe the effect, I'd really like to know what this means.  My impression is "one of the branches containing 'landed' code tracked from initial landing through release; such branches are allowed to share data through common index routes, etc."

I'm not sure that's correct, though!

        Attachment #8966259 -
        Flags: review?(dustin) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        comm-trunk.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8966259 -
        Attachment is obsolete: true

        Attachment #8966301 -
        Flags: review?(dustin)

        Attachment #8966301 -
        Flags: review?(dustin) → review+

    
    

    
  
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/50b945170f33
Add comm-central bracnhes to taskgraph project aliases; r=dustin a=reland

    
  
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.