1452107 - Helper to use regular FTL in recipe files

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: Fluent Migration, enhancement)

Description

[Staś Małolepszy :stas]

I wonder if we could modify or extend the migration code to accept recipes written as valid FTL files:

    connection-window =
         .title = { COPY("browser/chrome/browser/preferences/connection.dtd", "connectionsDialog.title") }
         .style = width: { PLATFORM() ->
             [macos] { COPY("browser/chrome/browser/preferences/connection.dtd", "window.macWidth2") }
            *[other] { COPY("browser/chrome/browser/preferences/connection.dtd", "window.width2") }
         }

We could then use FluentParser to get an AST which would then be fed into the migration code.

For feature parity with the current recipes, we'd need a way to define or replace lambda which are currently used together with REPLACE_IN_TEXT:


    FTL.Message(
        id=FTL.Identifier('containers-remove-alert-msg'),
        value=PLURALS(
            'browser/chrome/browser/preferences/preferences.properties',
            'removeContainerMsg',
            EXTERNAL_ARGUMENT('count'),
            lambda text: REPLACE_IN_TEXT(
                text,
                {
                     '#S': EXTERNAL_ARGUMENT('count')
                }
            )
        )
    ),

Comment 1

[Axel Hecht [:Pike]]

stas and I talked about this, keeping notes of that here.

We want to keep the regular python structure of the recipes. There's ton of meta data about commits, and whatnot, and also we don't want to make the testing surface of the recipes tooooooo ftl specific.

Instead, we want to use FTL just as a way to specify the transforms. We'll create a helper that you can use to parse FTL like in the comment that stas gave, and that'll create a valid list of transforms by extending the BUILTINS of the context in which we parse.

Best of both worlds.

Comment 2

[Staś Małolepszy :stas]

Thanks for the summary, Axel. Taking.

Comment 3

[Phabricator Automation]

Attachment: Bug 1452107 - Helper for using regular FTL to define recipes. r?Pike

Comment 4

[Phabricator Automation]

Comment on attachment 8969570 [details]
Bug 1452107 - Helper for using regular FTL to define recipes. r?Pike

Axel Hecht [:Pike] has approved the revision.

https://phabricator.services.mozilla.com/D1002

Comment 5

[Staś Małolepszy :stas]

Fixed in https://hg.mozilla.org/l10n/fluent-migration/rev/b2480df1105f.