Closed Bug 1452703 Opened 7 years ago Closed 4 years ago

WebRender-gecko integration is confusing

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: mikokm, Unassigned)

References

(Blocks 1 open bug)

Details

Changing WebRender behavior from layers-full to layers-free introduced some technical debt. The original implementation for layers-full mode is still very much present with, for example, WebRenderLayerManager. Sadly, as the majority of the layers-full code was removed, this implementation no longer follows the API set by LayerManager. Not following the API reduces the benefits of polymorphism and adds unnecessary complexity as seen here [1]. This also makes the code difficult to understand, when the functions do not behave as expected [2]. I wish I had some actionable ideas on how to improve this situation, but my knowledge of this code is very limited. [1]: https://searchfox.org/mozilla-central/rev/7ccb618f45a1398e31a086a009f87c8fd3a790b6/layout/painting/nsDisplayList.cpp#2614 [2]: https://searchfox.org/mozilla-central/rev/7ccb618f45a1398e31a086a009f87c8fd3a790b6/gfx/layers/wr/WebRenderLayerManager.cpp#623
Moving to p3 because no activity for at least 24 weeks.
Priority: P1 → P3
Blocks: gfx-complexity
No longer blocks: stage-wr-next

This has gotten better.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.